CaffGeek/MBACNationals

View on GitHub
Web.Admin/z-scripts/ng-file-upload-shim.js

Summary

Maintainability
F
3 wks
Test Coverage

File ng-file-upload-shim.js has 334 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**!
 * AngularJS file upload/drop directive and service with progress and abort
 * FileAPI Flash shim for old browsers not supporting FormData 
 * @author  Danial  <danial.farid@gmail.com>
 * @version 4.2.1
Severity: Minor
Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 4 hrs to fix

    Consider simplifying this complex logical expression.
    Open

    if ((window.XMLHttpRequest && !window.FormData) || (window.FileAPI && FileAPI.forceLoad)) {
        var initializeUploadListener = function(xhr) {
            if (!xhr.__listeners) {
                if (!xhr.upload) xhr.upload = {};
                xhr.__listeners = [];
    Severity: Critical
    Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 2 hrs to fix

      Function ngfFixIE has 66 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          FileAPI.ngfFixIE = function(elem, createFileElemFn, bindAttr, changeFn, resetModel) {
              if (!hasFlash()) {
                  throw 'Adode Flash Player need to be installed. To check ahead use "FileAPI.hasFlash"';
              }
              var makeFlashInput = function(evt) {
      Severity: Major
      Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 2 hrs to fix

        Function FileReader has 55 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            window.FileReader = function() {
                var _this = this, loadStarted = false;
                this.listeners = {};
                this.addEventListener = function(type, fn) {
                    _this.listeners[type] = _this.listeners[type] || [];
        Severity: Major
        Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 2 hrs to fix

          Function makeFlashInput has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  var makeFlashInput = function(evt) {
                      if (elem.attr('disabled')) {
                          elem.__ngf_elem__.removeClass('js-fileapi-wrapper');
                      } else {
                          var fileElem = elem.__ngf_elem__;
          Severity: Minor
          Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                if (index > -1) {
                                    basePath = src.substring(0, index + 1);
                                    break;
                                }
            Severity: Major
            Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 45 mins to fix

              Consider simplifying this complex logical expression.
              Open

                          if (arguments[0] && arguments[0].__isFileAPIShim) {
                              var formData = arguments[0];
                              var config = {
                                  url: xhr.__url,
                                  jsonp: false, //removes the callback form param
              Severity: Major
              Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 40 mins to fix

                Function ngfFixIE has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    FileAPI.ngfFixIE = function(elem, createFileElemFn, bindAttr, changeFn, resetModel) {
                Severity: Minor
                Found in Web.Admin/z-scripts/ng-file-upload-shim.js - About 35 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                  (function() {
                  
                  var hasFlash = function() {
                      try {
                        var fo = new ActiveXObject('ShockwaveFlash.ShockwaveFlash');
                  Severity: Major
                  Found in Web.Admin/z-scripts/ng-file-upload-shim.js and 1 other location - About 3 wks to fix
                  Web.Admin/z-scripts/ng-file-upload-all.js on lines 622..991

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 4067.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status