File ng-file-upload.js
has 554 lines of code (exceeds 250 allowed). Consider refactoring. Open
/**!
* AngularJS file upload/drop directive and service with progress and abort
* @author Danial <danial.farid@gmail.com>
* @version 4.2.1
*/
Function linkDrop
has 169 lines of code (exceeds 25 allowed). Consider refactoring. Open
function linkDrop(scope, elem, attr, ngModel, $parse, $timeout, $location) {
var available = dropAvailable();
if (attr.dropAvailable) {
$timeout(function () {
scope[attr.dropAvailable] ? scope[attr.dropAvailable].value = available : scope[attr.dropAvailable] = available;
Function extractFiles
has 96 lines of code (exceeds 25 allowed). Consider refactoring. Open
function extractFiles(evt, callback, allowDir, multiple) {
var files = [], rejFiles = [], items = evt.dataTransfer.items, processing = 0;
function addFile(file) {
if (validate(scope, $parse, attr, file, evt)) {
Function linkFileSelect
has 93 lines of code (exceeds 25 allowed). Consider refactoring. Open
function linkFileSelect(scope, elem, attr, ngModel, $parse, $timeout, $compile) {
if (elem.attr('__ngf_gen__')) {
return;
}
function isInputTypeFile() {
Function sendHttp
has 75 lines of code (exceeds 25 allowed). Consider refactoring. Open
function sendHttp(config) {
config.method = config.method || 'POST';
config.headers = config.headers || {};
config.transformRequest = config.transformRequest || function (data, headersGetter) {
if (window.ArrayBuffer && data instanceof window.ArrayBuffer) {
Function upload
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
this.upload = function (config) {
config.headers = config.headers || {};
config.headers['Content-Type'] = undefined;
config.transformRequest = config.transformRequest ?
(angular.isArray(config.transformRequest) ?
Function traverseFileTree
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
function traverseFileTree(files, entry, path) {
if (entry != null) {
if (entry.isDirectory) {
var filePath = (path || '') + entry.name;
addFile({name: entry.name, type: 'directory', path: filePath});
Consider simplifying this complex logical expression. Open
if (file &&
validate(scope, $parse, attr, file, null) &&
(!window.FileAPI || navigator.userAgent.indexOf('MSIE 8') === -1 || file.size < 20000) &&
(!window.FileAPI || navigator.userAgent.indexOf('MSIE 9') === -1 || file.size < 4000000)) {
$timeout(function() {
Function updateModel
has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
function updateModel($parse, $timeout, scope, ngModel, attr, fileChange, files, rejFiles, evt, noDelay) {
Function linkFileSelect
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function linkFileSelect(scope, elem, attr, ngModel, $parse, $timeout, $compile) {
Function linkDrop
has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
function linkDrop(scope, elem, attr, ngModel, $parse, $timeout, $location) {
Avoid deeply nested control flow statements. Open
if (angular.isString(val)) {
formData.append(key, val);
} else {
if (config.sendObjectsAsJsonBlob && angular.isObject(val)) {
formData.append(key, new Blob([val], {type: 'application/json'}));
Avoid deeply nested control flow statements. Open
if (angular.isDate(val)) {
val = val.toISOString();
}
Consider simplifying this complex logical expression. Open
if ((isInputTypeFile() && attribute.name !== 'type')
|| (attribute.name !== 'type' && attribute.name !== 'class' &&
attribute.name !== 'id' && attribute.name !== 'style')) {
fileElem.attr(attribute.name, attribute.value);
}
Function validate
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
function validate(scope, $parse, attr, file, evt) {
Identical blocks of code found in 2 locations. Consider refactoring. Open
(function () {
var key, i;
function patchXHR(fnName, newFn) {
window.XMLHttpRequest.prototype[fnName] = newFn(window.XMLHttpRequest.prototype[fnName]);
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 5995.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76