CalderaWP/caldera-api-client

View on GitHub
src/FormsClient.js

Summary

Maintainability
A
35 mins
Test Coverage

Strings must use singlequote.
Open

        return `forms`;
Severity: Minor
Found in src/FormsClient.js by eslint

enforce the consistent use of either backticks, double, or single quotes (quotes)

JavaScript allows you to define strings in one of three ways: double quotes, single quotes, and backticks (as of ECMAScript 6). For example:

/*eslint-env es6*/

var double = "double";
var single = 'single';
var backtick = `backtick`;    // ES6 only

Each of these lines creates a string and, in some cases, can be used interchangeably. The choice of how to define strings in a codebase is a stylistic one outside of template literals (which allow embedded of expressions to be interpreted).

Many codebases require strings to be defined in a consistent manner.

Rule Details

This rule enforces the consistent use of either backticks, double, or single quotes.

Options

This rule has two options, a string option and an object option.

String option:

  • "double" (default) requires the use of double quotes wherever possible
  • "single" requires the use of single quotes wherever possible
  • "backtick" requires the use of backticks wherever possible

Object option:

  • "avoidEscape": true allows strings to use single-quotes or double-quotes so long as the string contains a quote that would have to be escaped otherwise
  • "allowTemplateLiterals": true allows strings to use backticks

Deprecated: The object property avoid-escape is deprecated; please use the object property avoidEscape instead.

double

Examples of incorrect code for this rule with the default "double" option:

/*eslint quotes: ["error", "double"]*/

var single = 'single';
var unescaped = 'a string containing "double" quotes';

Examples of correct code for this rule with the default "double" option:

/*eslint quotes: ["error", "double"]*/
/*eslint-env es6*/

var double = "double";
var backtick = `back\ntick`;  // backticks are allowed due to newline
var backtick = tag`backtick`; // backticks are allowed due to tag

single

Examples of incorrect code for this rule with the "single" option:

/*eslint quotes: ["error", "single"]*/

var double = "double";
var unescaped = "a string containing 'single' quotes";

Examples of correct code for this rule with the "single" option:

/*eslint quotes: ["error", "single"]*/
/*eslint-env es6*/

var single = 'single';
var backtick = `back${x}tick`; // backticks are allowed due to substitution

backticks

Examples of incorrect code for this rule with the "backtick" option:

/*eslint quotes: ["error", "backtick"]*/

var single = 'single';
var double = "double";
var unescaped = 'a string containing `backticks`';

Examples of correct code for this rule with the "backtick" option:

/*eslint quotes: ["error", "backtick"]*/
/*eslint-env es6*/

var backtick = `backtick`;

avoidEscape

Examples of additional correct code for this rule with the "double", { "avoidEscape": true } options:

/*eslint quotes: ["error", "double", { "avoidEscape": true }]*/

var single = 'a string containing "double" quotes';

Examples of additional correct code for this rule with the "single", { "avoidEscape": true } options:

/*eslint quotes: ["error", "single", { "avoidEscape": true }]*/

var double = "a string containing 'single' quotes";

Examples of additional correct code for this rule with the "backtick", { "avoidEscape": true } options:

/*eslint quotes: ["error", "backtick", { "avoidEscape": true }]*/

var double = "a string containing `backtick` quotes"

allowTemplateLiterals

Examples of additional correct code for this rule with the "double", { "allowTemplateLiterals": true } options:

/*eslint quotes: ["error", "double", { "allowTemplateLiterals": true }]*/

var double = "double";
var double = `double`;

Examples of additional correct code for this rule with the "single", { "allowTemplateLiterals": true } options:

/*eslint quotes: ["error", "single", { "allowTemplateLiterals": true }]*/

var single = 'single';
var single = `single`;

When Not To Use It

If you do not need consistency in your string styles, you can safely disable this rule. Source: http://eslint.org/docs/rules/

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    deleteForm( formId: string ) : Promise<any> {
        return this.reqDelete(this.getFormEndpoint(formId));
    }
Severity: Minor
Found in src/FormsClient.js and 1 other location - About 35 mins to fix
src/EntriesClient.js on lines 53..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There must be a space after return type colon.
Open

    getFormsEndpoint() :string {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There must be no space before return type colon.
Open

    getFormsEndpoint() :string {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There must be no space before return type colon.
Open

    getFormEndpoint(formId: string) :string {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There must be no space before "args" parameter type annotation colon.
Open

    createForm(name: string, args : Object = {} ) :  Promise<any> {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There must be 1 space after return type colon.
Open

    createForm(name: string, args : Object = {} ) :  Promise<any> {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There must be no space before return type colon.
Open

    deleteForm( formId: string ) : Promise<any> {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There must be a space after return type colon.
Open

    getFormEndpoint(formId: string) :string {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

Definition for rule 'jest/prefer-to-have-length' was not found
Open

import {WpClient} from './WpClient';
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There must be no space before return type colon.
Open

    createForm(name: string, args : Object = {} ) :  Promise<any> {
Severity: Minor
Found in src/FormsClient.js by eslint

For more information visit Source: http://eslint.org/docs/rules/

There are no issues that match your filters.

Category
Status