Method main has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.

Open

    public static void main(String[] args) {
        boolean multipleTargets = args.length < 2 && args[0].startsWith("@");
        if (args.length < 1 && !multipleTargets) {
            showUsage();
            System.exit(-1);

• Read up
  Read up

Method parse_methods has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.

Open

  def parse_methods
    @methods = []
    method_signature = nil
    in_method = false
    body = nil

• Read up
  Read up

Method main has 53 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public static void main(String[] args) {
        boolean multipleTargets = args.length < 2 && args[0].startsWith("@");
        if (args.length < 1 && !multipleTargets) {
            showUsage();
            System.exit(-1);

Method parseTarget has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

    private static void parseTarget(Gson gson, InvocationTarget target) throws ClassNotFoundException, NoSuchMethodException {
        String[] args = target.getArgumentStrings();
        Class<?>[] parameterTypes = new Class[args.length];
        Object[] methodArguments = new Object[parameterTypes.length];
        for (int i = 0; i < parameterTypes.length; i++) {

• Read up
  Read up

Method apply_outputs has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.

Open

  def self.apply_outputs(target_id_to_output, method_to_target_to_contexts, modifier, filter = nil)
    made_changes = false
    method_to_target_to_contexts.each do |method, target_to_contexts|
      target_to_contexts.each do |target, contexts|
        status, output = target_id_to_output[target[:id]]

• Read up
  Read up

Method filter_methods has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.

Open

  def self.filter_methods(smali_files, include_types, exclude_types)
    methods = []
    smali_files.each do |smali_file|
      smali_file.methods.each do |method|
        if include_types

• Read up
  Read up

Method build_argument has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

  def build_argument(parameter, argument)
    if parameter[0] == 'L'
      java_type = parameter[1..-2].tr('/', '.')
      if java_type == 'java.lang.String'
        # Need to unescape smali string to get the actual string

• Read up
  Read up

Method smaliToJavaClass has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.

Open

    private static Class<?> smaliToJavaClass(String className) throws ClassNotFoundException {
        if (className.equals("I")) {
            return int.class;
        } else if (className.equals("V")) {
            return void.class;

• Read up
  Read up

Method prepare has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  def prepare(input)
    if File.directory?(input)
      @temp_dir = false
      @temp_dex = true
      @dir = input

Method parseTarget has 26 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    private static void parseTarget(Gson gson, InvocationTarget target) throws ClassNotFoundException, NoSuchMethodException {
        String[] args = target.getArgumentStrings();
        Class<?>[] parameterTypes = new Class[args.length];
        Object[] methodArguments = new Object[parameterTypes.length];
        for (int i = 0; i < parameterTypes.length; i++) {

Method install has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

  def install(dex)
    has_java = Utility.which('java')
    raise 'Unable to find Java on the path.' unless has_java

    begin

• Read up
  Read up

Method get_driver_dir has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

  def get_driver_dir
    # On some older devices, /data/local is world writable
    # But on other devices, it's /data/local/tmp
    %w(/data/local /data/local/tmp).each do |dir|
      stdout = adb("shell -x ls #{dir}")

• Read up
  Read up

Method unescape has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

  def unescape(str)
    str.gsub(UNESCAPE_REGEX) do
      if Regexp.last_match[1]
        if Regexp.last_match[1] == '\\'
          Regexp.last_match[1]

• Read up
  Read up

Method process_plugins has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

  def process_plugins
    made_changes = false
    loop do
      sweep_changes = false
      Plugin.plugins.each do |p|

• Read up
  Read up

Method plugin_classes has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

  def self.plugin_classes
    Dir["#{File.dirname(__FILE__)}/plugins/*.rb"].each { |f| require f }
    classes = []
    Object.constants.each do |klass|
      const = Kernel.const_get(klass) unless klass == :TimeoutError

• Read up
  Read up

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  def initialize(smali_dir, driver, include_types, exclude_types, disable_plugins)

Method exec has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

  def exec(cmd, silent = true)
    logger.debug("exec: #{cmd}")

    retries = 1
    begin

• Read up
  Read up

Method enumerate_files has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.

Open

  def self.enumerate_files(dir, ext)
    # On Windows, filenames with unicode characters do not show up with Dir#glob or Dir#[]
    # They do, however, show up with Dir.entries, which is fine because it seems to be
    # the only Dir method that let's me set UTF-8 encoding. I must be missing something.
    # OH WELL. Do it the hard way.

• Read up
  Read up

Avoid too many return statements within this method.

Open

            return byte.class;

Avoid too many return statements within this method.

Open

            return void.class;