CartoDB/cartodb20

View on GitHub
lib/assets/javascripts/builder/components/code-mirror/mode/sql.js

Summary

Maintainability
F
5 days
Test Coverage

Function exports has a Cognitive Complexity of 127 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function(CodeMirror) {
"use strict";

CodeMirror.defineMode("sql", function(config, parserConfig) {
  "use strict";
Severity: Minor
Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 200 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(CodeMirror) {
"use strict";

CodeMirror.defineMode("sql", function(config, parserConfig) {
  "use strict";
Severity: Major
Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 1 day to fix

    Function tokenBase has 61 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function tokenBase(stream, state) {
        var ch = stream.next();
    
        // call hooks from the mime type
        if (hooks[ch]) {
    Severity: Major
    Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

          } else if ((((support.nCharCast == true && (ch == "n" || ch == "N"))
              || (support.charsetCast == true && ch == "_" && stream.match(/[a-z][a-z0-9]*/i)))
              && (stream.peek() == "'" || stream.peek() == '"'))) {
            // charset casting: _utf8'str', N'str', n'str'
            // ref: http://dev.mysql.com/doc/refman/5.5/en/string-literals.html
      Severity: Critical
      Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 1 hr to fix

        Consider simplifying this complex logical expression.
        Open

            } else if (support.binaryNumber == true &&
              (((ch == "b" || ch == "B") && stream.match(/^'[01]+'/))
              || (ch == "0" && stream.match(/^b[01]+/)))) {
              // bitstring
              // ref: http://dev.mysql.com/doc/refman/5.5/en/bit-field-literals.html
        Severity: Major
        Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

              if (support.hexNumber == true &&
                ((ch == "0" && stream.match(/^[xX][0-9a-fA-F]+/))
                || (ch == "x" || ch == "X") && stream.match(/^'[0-9a-fA-F]+'/))) {
                // hex
                // ref: http://dev.mysql.com/doc/refman/5.5/en/hexadecimal-literals.html
          Severity: Major
          Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 40 mins to fix

            Consider simplifying this complex logical expression.
            Open

                } else if ((support.commentHash && ch == "#")
                    || (ch == "-" && stream.eat("-") && (!support.commentSpaceRequired || stream.eat(" ")))) {
                  // 1-line comments
                  // ref: https://kb.askmonty.org/en/comment-syntax/
                  stream.skipToEnd();
            Severity: Major
            Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 40 mins to fix

              Avoid too many return statements within this function.
              Open

                      return "number";
              Severity: Major
              Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return null;
                Severity: Major
                Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        if (builtin.hasOwnProperty(word)) return "builtin";
                  Severity: Major
                  Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return null;
                    Severity: Major
                    Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return null;
                      Severity: Major
                      Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return state.tokenize(stream, state);
                        Severity: Major
                        Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return "comment";
                          Severity: Major
                          Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                  return "variable-3";
                            Severity: Major
                            Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return "number";
                              Severity: Major
                              Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      return "comment";
                                Severity: Major
                                Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                          return "variable-2";
                                  Severity: Major
                                  Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                          return "keyword";
                                    Severity: Major
                                    Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                      Avoid too many return statements within this function.
                                      Open

                                            if (keywords.hasOwnProperty(word)) return "keyword";
                                      Severity: Major
                                      Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                        Avoid too many return statements within this function.
                                        Open

                                            return null;
                                        Severity: Major
                                        Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                          Avoid too many return statements within this function.
                                          Open

                                                return state.tokenize(stream, state);
                                          Severity: Major
                                          Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                            Avoid too many return statements within this function.
                                            Open

                                                  if (client.hasOwnProperty(word)) return "string-2";
                                            Severity: Major
                                            Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                              Avoid too many return statements within this function.
                                              Open

                                                    return "number";
                                              Severity: Major
                                              Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                                Avoid too many return statements within this function.
                                                Open

                                                      if (atoms.hasOwnProperty(word)) return "atom";
                                                Severity: Major
                                                Found in lib/assets/javascripts/builder/components/code-mirror/mode/sql.js - About 30 mins to fix

                                                  Identical blocks of code found in 2 locations. Consider refactoring.
                                                  Open

                                                    function popContext(state) {
                                                      state.indent = state.context.indent;
                                                      state.context = state.context.prev;
                                                    }
                                                  lib/assets/javascripts/utils/postgres.codemirror.js on lines 127..130

                                                  Duplicated Code

                                                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                                  Tuning

                                                  This issue has a mass of 47.

                                                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                                  Refactorings

                                                  Further Reading

                                                  There are no issues that match your filters.

                                                  Category
                                                  Status