CartoDB/cartodb20

View on GitHub
lib/assets/javascripts/builder/components/input-color/assets-picker/assets-view.js

Summary

Maintainability
D
2 days
Test Coverage

exports has 38 functions (exceeds 20 allowed). Consider refactoring.
Open

module.exports = CoreView.extend({
  className: 'Dialog-content Dialog-content--expanded',

  events: {
    'click .js-add': '_onSetImage',

    File assets-view.js has 368 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var $ = require('jquery');
    var _ = require('underscore');
    var CoreView = require('backbone/core-view');
    var Backbone = require('backbone');
    
    

      Function _initTabPane has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _initTabPane: function () {
          var tabPaneTabs = [{
            name: 'maki-icons',
            label: _t('components.modals.add-asset.icons'),
            createContentView: this._createMakiIconsView.bind(this)

        Function _initModels has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _initModels: function () {
            var self = this;
        
            this._selectedAsset = new Backbone.Model({
              url: this.model.get('image')

          Similar blocks of code found in 8 locations. Consider refactoring.
          Open

            _initBinds: function () {
              this.listenTo(this._selectedAsset, 'change:url', this._onChangeSelectedAsset);
              this.listenTo(this._stateModel, 'change:status', this.render);
              this.listenTo(this._stateModel, 'change:modalEnabled', this._onChangeSetButton);
            },
          lib/assets/javascripts/builder/components/input-color/input-quantitative-ramps/input-ramp-list-view.js on lines 72..76
          lib/assets/javascripts/builder/editor/layers/layer-content-views/analyses/analyses-view.js on lines 75..79
          lib/assets/javascripts/builder/editor/layers/layer-content-views/legend/legends-view.js on lines 76..80
          lib/assets/javascripts/builder/editor/layers/layers-view.js on lines 78..82
          lib/assets/javascripts/builder/editor/widgets/widgets-form/widgets-form-view.js on lines 43..47
          lib/assets/javascripts/dashboard/views/organization/icon-picker/organization-icon-picker-view.js on lines 50..54
          lib/assets/javascripts/deep-insights/widgets/formula/content-view.js on lines 112..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              this._userAssetCollection.create(data, {
                beforeSend: this._beforeAssetUpload.bind(this),
                success: this._onAssetUploaded.bind(this),
                error: this._onAssetUploadError.bind(this),
                complete: this._onAssetUploadComplete.bind(this)
          lib/assets/javascripts/dashboard/views/organization/icon-picker/icons/organization-icons-view.js on lines 118..123
          lib/assets/javascripts/dashboard/views/organization/icon-picker/icons/organization-icons-view.js on lines 235..240

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 70.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.trigger('change', {
                url: this._selectedAsset.get('url'),
                kind: this._selectedAsset.get('kind')
              }, this);
          lib/assets/javascripts/builder/components/color-picker/color-picker.js on lines 119..122

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status