CartoDB/cartodb20

View on GitHub
lib/assets/javascripts/builder/components/input-number/input-number-dialog-content.js

Summary

Maintainability
C
1 day
Test Coverage

Function _initViews has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _initViews: function () {
    var self = this;

    var fixedPane = {
      name: 'fixed',

    Function _initViews has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      _initViews: function () {
        var self = this;
    
        var fixedPane = {
          name: 'fixed',

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _generateFixedContentView has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      _generateFixedContentView: function () {
        var editorAttrs = this.options.editorAttrs;
        return new InputNumberFixedContentView({
          model: this.model,
          min: (editorAttrs && editorAttrs.min) || DEFAULT_INPUT_MIN_VALUE,

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (this.options.editorAttrs && this.options.editorAttrs.hidePanes) {
          var hidePanes = this.options.editorAttrs.hidePanes;
          if (!_.contains(hidePanes, FillConstants.Panes.FIXED)) {
            this._tabPaneTabs.push(fixedPane);
          }
    lib/assets/javascripts/builder/components/form-components/editors/fill-color/fill-color.js on lines 76..88

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 150.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        if (this.model.get('range') && this._tabPaneTabs.length > 1) {
          this._tabPaneTabs[1].selected = true;
        }
    lib/assets/javascripts/builder/components/input-color/input-color-dialog-content.js on lines 114..116
    lib/assets/javascripts/builder/components/input-color/input-color-fixed-content-view.js on lines 105..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 54.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

        var tabPaneOptions = {
          tabPaneOptions: {
            template: tabPaneTemplate,
            tabPaneItemOptions: {
              tagName: 'li',
    lib/assets/javascripts/builder/components/form-components/editors/fill-color/fill-color.js on lines 90..102
    lib/assets/javascripts/builder/components/form-components/editors/size/size.js on lines 94..106
    lib/assets/javascripts/builder/components/input-color/input-color-dialog-content.js on lines 100..112
    lib/assets/javascripts/builder/components/input-color/input-color-fixed-content-view.js on lines 91..103
    lib/assets/javascripts/builder/components/modals/publish/publish-view.js on lines 160..172
    lib/assets/javascripts/builder/editor/editor-pane.js on lines 176..188
    lib/assets/javascripts/builder/editor/layers/layer-content-views/infowindow/infowindows-view.js on lines 127..139
    lib/assets/javascripts/builder/editor/layers/layer-content-views/legend/legends-view.js on lines 120..132

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 51.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 26 locations. Consider refactoring.
    Open

      render: function () {
        this.clearSubViews();
        this.$el.empty();
        this._initViews();
        return this;
    lib/assets/javascripts/builder/components/form-components/editors/select/select-list-view.js on lines 38..43
    lib/assets/javascripts/builder/components/form-components/editors/size/size-by-value-view.js on lines 45..50
    lib/assets/javascripts/builder/components/infobox/infobox-item-view.js on lines 44..49
    lib/assets/javascripts/builder/components/infobox/infobox-view.js on lines 18..23
    lib/assets/javascripts/builder/components/input-color/assets-picker/user-assets-tab.js on lines 31..36
    lib/assets/javascripts/builder/components/input-color/input-color-dialog-content.js on lines 50..55
    lib/assets/javascripts/builder/components/input-color/input-color-value-content-view.js on lines 53..58
    lib/assets/javascripts/builder/components/input-color/input-quantitative-ramps/input-ramp-content-view.js on lines 15..20
    lib/assets/javascripts/builder/components/input-color/input-quantitative-ramps/main-view.js on lines 21..26
    lib/assets/javascripts/builder/components/input-fill/input-fill-view.js on lines 49..55
    lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js on lines 32..37
    lib/assets/javascripts/builder/components/modals/export-data/modal-export-data-format-view.js on lines 19..24
    lib/assets/javascripts/builder/components/modals/publish/share/share-list-view.js on lines 29..34
    lib/assets/javascripts/builder/components/modals/publish/upgrade-view.js on lines 11..16
    lib/assets/javascripts/builder/dataset/dataset-options/dataset-sql-view.js on lines 30..35
    lib/assets/javascripts/builder/editor/layers/layer-content-views/analyses/analyses-workflow-view.js on lines 23..30
    lib/assets/javascripts/builder/editor/layers/layer-content-views/analyses/analysis-quota-view.js on lines 15..20
    lib/assets/javascripts/builder/editor/layers/layer-content-views/data/data-sql-view.js on lines 32..37
    lib/assets/javascripts/builder/editor/layers/layer-content-views/data/stat-view.js on lines 28..33
    lib/assets/javascripts/builder/editor/layers/layer-content-views/infowindow/infowindow-content-view.js on lines 24..31
    lib/assets/javascripts/builder/editor/layers/layer-content-views/infowindow/infowindow-html-view.js on lines 20..25
    lib/assets/javascripts/builder/editor/layers/layer-content-views/legend/legend-editor-view.js on lines 23..28
    lib/assets/javascripts/builder/editor/settings/preview/preview-view.js on lines 20..25
    lib/assets/javascripts/dashboard/views/organization/groups-admin/groups-list/groups-list-view.js on lines 16..21
    lib/assets/javascripts/deep-insights/widgets/category/paginator/paginator-view.js on lines 43..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status