Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js

Summary

Maintainability
F
3 days
Test Coverage

Function _initViews has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _initViews: function () {
    var self = this;

    var stackViewCollection = new Backbone.Collection([{
      createStackView: function (stackLayoutModel, opts) {
Severity: Minor
Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js - About 1 hr to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

      _setupModel: function () {
    var options = {};

    if (!this.model.get('quantification')) {
      options.quantification = this._settings.quantifications.items[this._settings.quantifications.defaultIndex];
    Severity: Major
    Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js and 1 other location - About 1 day to fix
    lib/assets/javascripts/builder/components/input-color/input-quantitative-ramps/main-view.js on lines 28..44

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 263.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      _createQuantificationListView: function (stackLayoutModel, opts) {
    var view = new ColumnListView({
      headerTitle: _t('form-components.editors.fill.quantification.title'),
      stackLayoutModel: stackLayoutModel,
      columns: this._settings.quantifications.items,
    Severity: Major
    Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js and 1 other location - About 5 hrs to fix
    lib/assets/javascripts/builder/components/form-components/editors/size/size-by-value-view.js on lines 237..264

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 150.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      _createBinsListView: function (stackLayoutModel, opts) {
    var view = new ColumnListView({
      headerTitle: _t('form-components.editors.fill.bins'),
      stackLayoutModel: stackLayoutModel,
      columns: this._settings.bins.items
    Severity: Major
    Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js and 1 other location - About 5 hrs to fix
    lib/assets/javascripts/builder/components/input-color/input-quantitative-ramps/main-view.js on lines 151..168

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 142.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var view = new ColumnListView({
      stackLayoutModel: stackLayoutModel,
      columns: this._columns.filter(function (f) {
        return f.type === 'number';
      }),
    Severity: Major
    Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js and 1 other location - About 1 hr to fix
    lib/assets/javascripts/builder/components/form-components/editors/size/size-by-value-view.js on lines 177..184

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        if (!this.model.get('attribute')) {
      position = COLUMN_PANE_INDEX;
    } else if (!this.model.get('quantification')) {
      position = QUANTIFICATION_PANE_INDEX;
    }
    Severity: Major
    Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js and 1 other location - About 1 hr to fix
    lib/assets/javascripts/builder/components/form-components/editors/size/size-by-value-view.js on lines 168..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        var view = new InputNumberContentView({
      stackLayoutModel: stackLayoutModel,
      model: this.model,
      min: this.options.min,
      max: this.options.max
    Severity: Minor
    Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js and 1 other location - About 50 mins to fix
    lib/assets/javascripts/builder/components/form-components/editors/size/size-by-value-view.js on lines 203..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 26 locations. Consider refactoring.
    Open

      render: function () {
    this.clearSubViews();
    this.$el.empty();
    this._initViews();
    return this;
    Severity: Major
    Found in lib/assets/javascripts/builder/components/input-number/input-number-value-content-view.js and 25 other locations - About 35 mins to fix
    lib/assets/javascripts/builder/components/form-components/editors/select/select-list-view.js on lines 38..43
    lib/assets/javascripts/builder/components/form-components/editors/size/size-by-value-view.js on lines 45..50
    lib/assets/javascripts/builder/components/infobox/infobox-item-view.js on lines 44..49
    lib/assets/javascripts/builder/components/infobox/infobox-view.js on lines 18..23
    lib/assets/javascripts/builder/components/input-color/assets-picker/user-assets-tab.js on lines 31..36
    lib/assets/javascripts/builder/components/input-color/input-color-dialog-content.js on lines 50..55
    lib/assets/javascripts/builder/components/input-color/input-color-value-content-view.js on lines 53..58
    lib/assets/javascripts/builder/components/input-color/input-quantitative-ramps/input-ramp-content-view.js on lines 15..20
    lib/assets/javascripts/builder/components/input-color/input-quantitative-ramps/main-view.js on lines 21..26
    lib/assets/javascripts/builder/components/input-fill/input-fill-view.js on lines 49..55
    lib/assets/javascripts/builder/components/input-number/input-number-dialog-content.js on lines 21..26
    lib/assets/javascripts/builder/components/modals/export-data/modal-export-data-format-view.js on lines 19..24
    lib/assets/javascripts/builder/components/modals/publish/share/share-list-view.js on lines 29..34
    lib/assets/javascripts/builder/components/modals/publish/upgrade-view.js on lines 11..16
    lib/assets/javascripts/builder/dataset/dataset-options/dataset-sql-view.js on lines 30..35
    lib/assets/javascripts/builder/editor/layers/layer-content-views/analyses/analyses-workflow-view.js on lines 23..30
    lib/assets/javascripts/builder/editor/layers/layer-content-views/analyses/analysis-quota-view.js on lines 15..20
    lib/assets/javascripts/builder/editor/layers/layer-content-views/data/data-sql-view.js on lines 32..37
    lib/assets/javascripts/builder/editor/layers/layer-content-views/data/stat-view.js on lines 28..33
    lib/assets/javascripts/builder/editor/layers/layer-content-views/infowindow/infowindow-content-view.js on lines 24..31
    lib/assets/javascripts/builder/editor/layers/layer-content-views/infowindow/infowindow-html-view.js on lines 20..25
    lib/assets/javascripts/builder/editor/layers/layer-content-views/legend/legend-editor-view.js on lines 23..28
    lib/assets/javascripts/builder/editor/settings/preview/preview-view.js on lines 20..25
    lib/assets/javascripts/dashboard/views/organization/groups-admin/groups-list/groups-list-view.js on lines 16..21
    lib/assets/javascripts/deep-insights/widgets/category/paginator/paginator-view.js on lines 43..50

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status