Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js

Summary

Maintainability
D
1 day
Test Coverage

Function _getPgStats has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  _getPgStats: function (table, callback) {
    var userModel = this.userModel;
    var self = this;
    if (this.tables[table]) {
      if (!_.isEmpty(this.tables[table])) {
Severity: Major
Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 3 hrs to fix

    File tablestats.js has 284 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var CDB = require('internal-carto.js');
var _ = require('underscore');

function TableStats (opts) {
  if (opts.user && opts.api_key) {
    Severity: Minor
    Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 2 hrs to fix

      Function _generateHistogram has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _generateHistogram: function (width, height, color, bins) {
    var histogram;

    if (_.isEmpty(this.stats)) {
      return;
      Severity: Minor
      Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 1 hr to fix

        Function rows has 39 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                var rows = data.rows.map(function (r) {
          var count = r.reltuples;
          var bounds = self._reformatToJSON(r.histogram_bounds);
          if (bounds) {
            var avgs = bounds.reduce(function (p, c, i) {
        Severity: Minor
        Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 1 hr to fix

          Function _getHistogramFromBounds has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _getHistogramFromBounds: function (bins) {
    var bounds = this.stats.histogram_bounds;
    bounds = bounds.sort(function (a, b) { return a - b; });
    var min = bounds[0];
    var max = bounds[bounds.length - 1];
          Severity: Minor
          Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 1 hr to fix

            Function _generateCategory has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _generateCategory: function (width, height, color) {
    if (!this.stats.freqs) return;
    var canvas = document.createElement('canvas');
    var context = canvas.getContext('2d');
    var proportion;
            Severity: Minor
            Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 1 hr to fix

              Function _generateHistogram has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                _generateHistogram: function (width, height, color, bins) {
    var histogram;

    if (_.isEmpty(this.stats)) {
      return;
              Severity: Minor
              Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _getHistogramFromBounds has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                _getHistogramFromBounds: function (bins) {
    var bounds = this.stats.histogram_bounds;
    bounds = bounds.sort(function (a, b) { return a - b; });
    var min = bounds[0];
    var max = bounds[bounds.length - 1];
              Severity: Minor
              Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    var sql = new CDB.SQL({
        user: this.configModel.get('user_name'),
        sql_api_template: this.configModel.get('sql_api_template'),
        api_key: this.configModel.get('api_key')
      });
              Severity: Major
              Found in lib/assets/javascripts/builder/components/modals/add-widgets/tablestats.js and 1 other location - About 1 hr to fix
              lib/assets/javascripts/builder/components/input-color/input-qualitative-ramps/main-view.js on lines 143..147

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 67.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status