Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/builder/components/table/head/table-head-item-view.js

Summary

Maintainability
D
2 days
Test Coverage

File table-head-item-view.js has 303 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var $ = require('jquery');
var CoreView = require('backbone/core-view');
var template = require('./table-head-item.tpl');
var ContextMenuView = require('builder/components/context-menu/context-menu-view');
var CustomListCollection = require('builder/components/custom-list/custom-list-collection');
Severity: Minor
Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js - About 3 hrs to fix

    Function _showContextMenu has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _showContextMenu: function (ev) {
    var self = this;
    var position = { x: ev.clientX, y: ev.clientY };
    var elementIndex = this.$el.index();
    var modelCID = this.model.cid;
    Severity: Major
    Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js - About 3 hrs to fix

      exports has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      module.exports = CoreView.extend({

  className: 'Table-headItem',
  tagName: 'th',
      Severity: Minor
      Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js - About 2 hrs to fix

        Function _changeColumnType has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _changeColumnType: function (newType) {
    var self = this;
    var oldType = this.model.get('type');
    var isTypeChangeDestructive = QueryColumnModel.isTypeChangeDestructive(oldType, newType);
    if (!isTypeChangeDestructive) {
        Severity: Minor
        Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js - About 1 hr to fix

          Function _saveNewName has 36 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _saveNewName: function () {
    if (this.model.isEditable()) {
      var newName = this.$('.js-attribute').val();
      var columnModel = this.model;
      var oldName = columnModel.get('name');
          Severity: Minor
          Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js - About 1 hr to fix

            Function _removeColumn has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              _removeColumn: function () {
    var self = this;
    this._modals.create(
      function (modalModel) {
        return new ConfirmationModalView({
            Severity: Minor
            Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js - About 1 hr to fix

              Function _showContextMenu has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                _showContextMenu: function (ev) {
    var self = this;
    var position = { x: ev.clientX, y: ev.clientY };
    var elementIndex = this.$el.index();
    var modelCID = this.model.cid;
              Severity: Minor
              Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                _hideContextMenu: function () {
    this._unhighlightHead();
    this._destroyScrollBinding();
    this._menuView.collection.unbind(null, null, this);
    this.removeView(this._menuView);
              Severity: Major
              Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js and 1 other location - About 2 hrs to fix
              lib/assets/javascripts/builder/components/table/body/table-body-view.js on lines 215..222

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 89.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          runAction: function () {
              changeColumnTypeOperation({
                columnModel: self.model,
                newType: newType,
                onSuccess: function () {
              Severity: Major
              Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js and 1 other location - About 1 hr to fix
              lib/assets/javascripts/builder/components/table/body/table-body-view.js on lines 461..472

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 6 locations. Consider refactoring.
              Open

                  this._menuView.model.bind('change:visible', function (model, isContextMenuVisible) {
      if (this._hasContextMenu() && !isContextMenuVisible) {
        this._hideContextMenu();
      }
    }, this);
              Severity: Major
              Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js and 5 other locations - About 1 hr to fix
              lib/assets/javascripts/builder/components/context-menu-factory-view.js on lines 70..74
              lib/assets/javascripts/builder/components/table/body/table-body-view.js on lines 305..309
              lib/assets/javascripts/builder/editor/layers/basemap-content-views/basemap-mosaic-remove-view.js on lines 59..63
              lib/assets/javascripts/builder/editor/layers/layer-header-view.js on lines 329..333
              lib/assets/javascripts/builder/editor/layers/layer-views/data-layer-view.js on lines 403..407

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                clean: function () {
    this._destroyRenameBinds();
    this._destroyScrollBinding();
    CoreView.prototype.clean.apply(this);
  }
              Severity: Major
              Found in lib/assets/javascripts/builder/components/table/head/table-head-item-view.js and 3 other locations - About 40 mins to fix
              lib/assets/javascripts/builder/components/custom-list/custom-list-view.js on lines 216..220
              lib/assets/javascripts/builder/components/date-picker/date-picker-view.js on lines 133..137
              lib/assets/javascripts/builder/editor/layers/layer-content-view.js on lines 650..654

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status