Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/builder/data/layer-definition-model.js

Summary

Maintainability
D
2 days
Test Coverage

File layer-definition-model.js has 377 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var Backbone = require('backbone');
var _ = require('underscore');
var syncAbort = require('./backbone/sync-abort');
var StyleDefinitionModel = require('builder/editor/style/style-definition-model');
var StyleCartoCSSModel = require('builder/editor/style/style-cartocss-model');
Severity: Minor
Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 5 hrs to fix

    exports has 37 functions (exceeds 20 allowed). Consider refactoring.
    Open

    module.exports = Backbone.Model.extend({

  /**
   * @override {Backbone.prototype.sync} abort ongoing request if there is any
   */
    Severity: Minor
    Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 4 hrs to fix

      Function parse has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        parse: function (response, opts) {
    response.options = response.options || {};

    // Flatten the attrs, to avoid having this.get('options').foobar internally
    var attrs = _
      Severity: Minor
      Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 1 hr to fix

        Function parse has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          parse: function (response, opts) {
    response.options = response.options || {};

    // Flatten the attrs, to avoid having this.get('options').foobar internally
    var attrs = _
        Severity: Minor
        Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function getAllDependentLayers has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          getAllDependentLayers: function () {
    var self = this;
    var layersCount = 0;

    var layerDefinitionsCollectionModels = self.collection.models;
        Severity: Minor
        Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function toJSON has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          toJSON: function () {
    // Un-flatten the internal attrs to the datastructure that's expected by the API endpoint
    var options = _.omit(this.attributes, ATTR_NAMES.concat(['cartocss', 'sql', 'autoStyle']));

    // Map back internal attrs to the expected attrs names by the API endpoint
        Severity: Minor
        Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 1 hr to fix

          Function toJSON has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            toJSON: function () {
    // Un-flatten the internal attrs to the datastructure that's expected by the API endpoint
    var options = _.omit(this.attributes, ATTR_NAMES.concat(['cartocss', 'sql', 'autoStyle']));

    // Map back internal attrs to the expected attrs names by the API endpoint
          Severity: Minor
          Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

              return false;
          Severity: Major
          Found in lib/assets/javascripts/builder/data/layer-definition-model.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (response.infowindow) {
      if (!this.infowindowModel) {
        this.infowindowModel = new InfowindowModel(response.infowindow, {
          configModel: opts.configModel || this._configModel
        });
            Severity: Major
            Found in lib/assets/javascripts/builder/data/layer-definition-model.js and 1 other location - About 1 hr to fix
            lib/assets/javascripts/builder/data/layer-definition-model.js on lines 56..62

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (response.tooltip) {
      if (!this.tooltipModel) {
        this.tooltipModel = new TooltipModel(response.tooltip, {
          configModel: opts.configModel || this._configModel
        });
            Severity: Major
            Found in lib/assets/javascripts/builder/data/layer-definition-model.js and 1 other location - About 1 hr to fix
            lib/assets/javascripts/builder/data/layer-definition-model.js on lines 49..55

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status