Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/builder/data/upload-model.js

Summary

Maintainability
F
6 days
Test Coverage

Function validate has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
Open

  validate: function (attrs) {
    if (!attrs) return;

    if (attrs.type === 'file') {
      // Number of files
Severity: Minor
Found in lib/assets/javascripts/builder/data/upload-model.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function validate has 88 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  validate: function (attrs) {
    if (!attrs) return;

    if (attrs.type === 'file') {
      // Number of files
Severity: Major
Found in lib/assets/javascripts/builder/data/upload-model.js - About 3 hrs to fix

    Function upload has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      upload: function () {
    if (this.get('type') === 'file') {
      var self = this;
      this.xhr = this.save(
        {
    Severity: Minor
    Found in lib/assets/javascripts/builder/data/upload-model.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return {
          msg: _t('data.upload-model.url-invalid')
        };
      Severity: Major
      Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return {
          msg: _t('data.upload-model.visualization-id')
        };
        Severity: Major
        Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return {
          msg: _t('data.upload-model.remote-file-size'),
          error_code: 8001
        };
          Severity: Major
          Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return {
          msg: _t('data.upload-model.query-undefined')
        };
            Severity: Major
            Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return {
          msg: _t('data.upload-model.twitter-categories-invalid')
        };
              Severity: Major
              Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return {
          msg: _t('data.upload-model.twitter-dates-invalid')
        };
                Severity: Major
                Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return {
          msg: _t('data.upload-model.file-size'),
          error_code: 8001
        };
                  Severity: Major
                  Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return {
          msg: _t('data.upload-model.twitter-dates-empty')
        };
                    Severity: Major
                    Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                              return {
          msg: _t('data.upload-model.twitter-data')
        };
                      Severity: Major
                      Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return {
          msg: _t('data.upload-model.dataset-copy-undefined')
        };
                        Severity: Major
                        Found in lib/assets/javascripts/builder/data/upload-model.js - About 30 mins to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                            validate: function (attrs) {
    if (!attrs) return;

    if (attrs.type === 'file') {
      // Number of files
                          Severity: Major
                          Found in lib/assets/javascripts/builder/data/upload-model.js and 1 other location - About 4 days to fix
                          lib/assets/javascripts/dashboard/data/upload-model.js on lines 8..118

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 730.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                            setFresh: function (d) {
    if (d && !_.isEmpty(d)) {
      // Set upload properties except create_vis (defined when created)
      this.set(_.omit(d, 'create_vis'));
    } else {
                          Severity: Major
                          Found in lib/assets/javascripts/builder/data/upload-model.js and 1 other location - About 1 hr to fix
                          lib/assets/javascripts/cartodb/common/background_polling/models/upload_model.js on lines 45..52

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 68.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                            defaults: {
    type: '',
    value: '',
    interval: 0,
    privacy: '',
                          Severity: Major
                          Found in lib/assets/javascripts/builder/data/upload-model.js and 1 other location - About 1 hr to fix
                          lib/assets/javascripts/cartodb/common/background_polling/models/upload_model.js on lines 19..32

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 66.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                this.set({
        state: 'error',
        error_code: (d && d.error_code) || '',
        get_error_text: {
          title: _t('data.upload-model.invalid-import'),
                          Severity: Major
                          Found in lib/assets/javascripts/builder/data/upload-model.js and 1 other location - About 1 hr to fix
                          lib/assets/javascripts/builder/data/asset-model.js on lines 35..42

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 56.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Open

                                      if (msg && msg.status === 429) {
              var response = JSON.parse(msg.responseText);
              message = response.errors.imports;
            }
                          Severity: Minor
                          Found in lib/assets/javascripts/builder/data/upload-model.js and 1 other location - About 55 mins to fix
                          lib/assets/javascripts/cartodb/common/background_polling/models/upload_model.js on lines 215..218

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 53.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status