CartoDB/cartodb20

View on GitHub
lib/assets/javascripts/builder/data/vis-definition-model.js

Summary

Maintainability
B
5 hrs
Test Coverage

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  vizjsonURL: function () {
    var baseUrl = this._configModel.get('base_url');
    var version = this._configModel.urlVersion('vizjson', 'read', 'v3');
    return baseUrl + '/api/' + version + '/viz/' + this.id + '/viz.json';
  },
Severity: Major
Found in lib/assets/javascripts/builder/data/vis-definition-model.js and 1 other location - About 2 hrs to fix
lib/assets/javascripts/builder/data/visualization-table-model.js on lines 70..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 77.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 9 locations. Consider refactoring.
Open

  urlRoot: function () {
    var baseUrl = this._configModel.get('base_url');
    var version = this._configModel.urlVersion('visualization');
    return baseUrl + '/api/' + version + '/viz';
  },
lib/assets/javascripts/builder/components/modals/add-layer/content/imports/import-bigquery/billing-project-model.js on lines 13..17
lib/assets/javascripts/builder/data/background-importer/import-model.js on lines 24..29
lib/assets/javascripts/builder/data/permission-model.js on lines 23..27
lib/assets/javascripts/builder/data/synchronization-model.js on lines 31..35
lib/assets/javascripts/builder/data/table-model.js on lines 28..32
lib/assets/javascripts/builder/data/tables-collection.js on lines 39..43
lib/assets/javascripts/builder/data/visualization-table-model.js on lines 16..20
lib/assets/javascripts/builder/data/visualizations-collection.js on lines 45..49

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 63.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  stateURL: function () {
    var baseUrl = this._configModel.get('base_url');
    return baseUrl + '/api/v3/viz/' + this.id + '/state';
  },
Severity: Major
Found in lib/assets/javascripts/builder/data/vis-definition-model.js and 6 other locations - About 40 mins to fix
lib/assets/javascripts/builder/data/analysis-definitions-collection.js on lines 32..35
lib/assets/javascripts/builder/data/layer-definitions-collection.js on lines 33..36
lib/assets/javascripts/builder/data/vis-definition-model.js on lines 49..52
lib/assets/javascripts/builder/data/vis-definition-model.js on lines 62..65
lib/assets/javascripts/builder/data/widget-definitions-collection.js on lines 75..78
lib/assets/javascripts/dashboard/data/visualization-model.js on lines 265..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  mapcapsURL: function () {
    var baseUrl = this._configModel.get('base_url');
    return baseUrl + '/api/v3/viz/' + this.id + '/mapcaps';
  },
Severity: Major
Found in lib/assets/javascripts/builder/data/vis-definition-model.js and 6 other locations - About 40 mins to fix
lib/assets/javascripts/builder/data/analysis-definitions-collection.js on lines 32..35
lib/assets/javascripts/builder/data/layer-definitions-collection.js on lines 33..36
lib/assets/javascripts/builder/data/vis-definition-model.js on lines 62..65
lib/assets/javascripts/builder/data/vis-definition-model.js on lines 73..76
lib/assets/javascripts/builder/data/widget-definitions-collection.js on lines 75..78
lib/assets/javascripts/dashboard/data/visualization-model.js on lines 265..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 7 locations. Consider refactoring.
Open

  builderURL: function () {
    var baseUrl = this._configModel.get('base_url');
    return baseUrl + '/builder/' + this.id + '/';
  },
Severity: Major
Found in lib/assets/javascripts/builder/data/vis-definition-model.js and 6 other locations - About 40 mins to fix
lib/assets/javascripts/builder/data/analysis-definitions-collection.js on lines 32..35
lib/assets/javascripts/builder/data/layer-definitions-collection.js on lines 33..36
lib/assets/javascripts/builder/data/vis-definition-model.js on lines 49..52
lib/assets/javascripts/builder/data/vis-definition-model.js on lines 73..76
lib/assets/javascripts/builder/data/widget-definitions-collection.js on lines 75..78
lib/assets/javascripts/dashboard/data/visualization-model.js on lines 265..268

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status