Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/builder/editor/layers/layer-content-view.js

Summary

Maintainability
F
4 days
Test Coverage

File layer-content-view.js has 553 lines of code (exceeds 250 allowed). Consider refactoring.
Open

var _ = require('underscore');
var $ = require('jquery');
var Backbone = require('backbone');
var CoreView = require('backbone/core-view');
var createTextLabelsTabPaneRouted = require('builder/components/tab-pane/create-text-labels-tab-pane-routed');
Severity: Major
Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js - About 1 day to fix

    Function _renderLayerTabPaneView has 203 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _renderLayerTabPaneView: function () {
    var self = this;
    var analysisPayload = this.options.analysisPayload;
    var layerId = this._layerDefinitionModel.get('id');
    var canBeGeoreferenced = this._viewState.get('canBeGeoreferenced');
    Severity: Major
    Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js - About 1 day to fix

      exports has 28 functions (exceeds 20 allowed). Consider refactoring.
      Open

      module.exports = CoreView.extend({
  module: 'editor:layers:layer-content-view',

  events: {
    'click .js-back': '_onClickBack',
      Severity: Minor
      Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js - About 3 hrs to fix

        Function _renderLayerTabPaneView has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
        Open

          _renderLayerTabPaneView: function () {
    var self = this;
    var analysisPayload = this.options.analysisPayload;
    var layerId = this._layerDefinitionModel.get('id');
    var canBeGeoreferenced = this._viewState.get('canBeGeoreferenced');
        Severity: Minor
        Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createContentView has 70 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              createContentView: function () {
        var layerDefinitionModel = self._layerDefinitionModel;
        var analysisSourceOptionsModel = new AnalysisSourceOptionsModel(null, {
          analysisDefinitionNodesCollection: self._analysisDefinitionNodesCollection,
          layerDefinitionsCollection: self._layerDefinitionsCollection,
        Severity: Major
        Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js - About 2 hrs to fix

          Function _initBinds has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _initBinds: function () {
    var querySchemaModel = this._getQuerySchemaModel();
    var queryRowsCollection = this._getQueryRowsCollection();
    var queryGeometryModel = this._getQueryGeometryModel();
    var layerDefinitionModel = this._layerDefinitionModel;
          Severity: Minor
          Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    return new LegendsView({
          className: 'Editor-content',
          mapDefinitionModel: self._mapDefinitionModel,
          userActions: self._userActions,
          layerDefinitionModel: self._layerDefinitionModel,
            Severity: Major
            Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js and 1 other location - About 3 hrs to fix
            lib/assets/javascripts/builder/editor/layers/layer-content-views/analyses/analyses-view.js on lines 124..137

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 112.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

              _initViewState: function () {
    this._viewState = new Backbone.Model({
      isLayerEmpty: false,
      canBeGeoreferenced: false,
      isLayerDone: false
            Severity: Major
            Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js and 2 other locations - About 1 hr to fix
            lib/assets/javascripts/builder/editor/layers/layer-content-views/data/data-content-view.js on lines 38..46
            lib/assets/javascripts/builder/editor/layers/layer-header-view.js on lines 104..111

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 55.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

              clean: function () {
    this._destroyContextButtons();
    this._destroyTable();
    CoreView.prototype.clean.apply(this);
  }
            Severity: Major
            Found in lib/assets/javascripts/builder/editor/layers/layer-content-view.js and 3 other locations - About 40 mins to fix
            lib/assets/javascripts/builder/components/custom-list/custom-list-view.js on lines 216..220
            lib/assets/javascripts/builder/components/date-picker/date-picker-view.js on lines 133..137
            lib/assets/javascripts/builder/components/table/head/table-head-item-view.js on lines 345..349

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status