Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/builder/editor/style/style-form/style-form-view.js

Summary

Maintainability
B
5 hrs
Test Coverage

Function initialize has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  initialize: function (opts) {
    if (!opts.layerDefinitionsCollection) throw new Error('layerDefinitionsCollection is required');
    if (!opts.layerDefinitionModel) throw new Error('layerDefinitionModel is required');
    if (!opts.querySchemaModel) throw new Error('querySchemaModel is required');
    if (!opts.queryGeometryModel) throw new Error('queryGeometryModel is required');
Severity: Minor
Found in lib/assets/javascripts/builder/editor/style/style-form/style-form-view.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    var propertiesFormView = new StylePropertiesFormView({
      styleModel: this._styleModel,
      layerDefinitionsCollection: this._layerDefinitionsCollection,
      configModel: this._configModel,
      userModel: this._userModel,
Severity: Major
Found in lib/assets/javascripts/builder/editor/style/style-form/style-form-view.js and 2 other locations - About 2 hrs to fix
lib/assets/javascripts/builder/components/input-color/input-color-value-content-view.js on lines 110..119
lib/assets/javascripts/builder/editor/style/style-content-view.js on lines 255..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 84.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      var aggregationFormView = new StyleAggregationFormView({
        styleModel: this._styleModel,
        queryGeometryModel: this._queryGeometryModel,
        querySchemaModel: this._querySchemaModel,
        configModel: this._configModel,
Severity: Major
Found in lib/assets/javascripts/builder/editor/style/style-form/style-form-view.js and 2 other locations - About 1 hr to fix
lib/assets/javascripts/builder/components/input-color/assets-picker/user-assets-tab.js on lines 41..48
lib/assets/javascripts/builder/components/modals/add-analysis/add-analysis-view.js on lines 77..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 15 locations. Consider refactoring.
Open

  _initBinds: function () {
    this._styleModel.bind('change:type', this.render, this);
    this.add_related_model(this._styleModel);
  },
Severity: Major
Found in lib/assets/javascripts/builder/editor/style/style-form/style-form-view.js and 14 other locations - About 35 mins to fix
lib/assets/javascripts/builder/components/background-importer/background-import-limit-view.js on lines 28..31
lib/assets/javascripts/builder/components/modals/add-layer/content/datasets/datasets-list-view.js on lines 32..35
lib/assets/javascripts/builder/components/modals/dataset-metadata/dataset-metadata-view.js on lines 99..102
lib/assets/javascripts/builder/components/modals/editor-visualization-warning/editor-visualization-warning-view.js on lines 39..42
lib/assets/javascripts/builder/components/modals/map-metadata/map-metadata-view.js on lines 93..96
lib/assets/javascripts/builder/components/modals/publish/share-with-view.js on lines 75..78
lib/assets/javascripts/builder/editor/layers/analysis-views/default-layer-analysis-view.js on lines 46..49
lib/assets/javascripts/builder/editor/layers/layer-content-views/data/data-sql-view.js on lines 39..42
lib/assets/javascripts/builder/editor/layers/layer-content-views/data/stat-view.js on lines 35..38
lib/assets/javascripts/builder/editor/layers/share-button-view.js on lines 33..36
lib/assets/javascripts/builder/editor/settings/preview/preview-options-view.js on lines 36..39
lib/assets/javascripts/cartodb/common/background_polling/views/analysis/background_analysis_item_view.js on lines 40..43
lib/assets/javascripts/cartodb/common/dialogs/georeference/choose_geometry_view.js on lines 72..75
lib/assets/javascripts/cartodb/table/menu_modules/wizards/category_wizard.js on lines 160..163

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status