CartoDB/cartodb20

Permission has 31 functions (exceeds 20 allowed). Consider refactoring.

Open

cdb.admin.Permission = cdb.core.Model.extend({


  urlRoot: '/api/v1/perm',

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  toJSON: function() {
    var entity = _.pick(this.get('entity').toJSON(), 'id', 'username', 'avatar_url', 'name');
    // translate name to username
    if (!entity.username) {
      entity.username = entity.name;

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

  _grantAccess: function(model, access) {
    var aclItem = this._ownAclItem(model);
    if (aclItem) {
      aclItem.set('access', access);
    } else {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  findRepresentableAclItem: function(model) {
    if (this.isOwner(model)) {
      return this._newAclItem(model, this.constructor.READ_WRITE);
    } else {
      var checkList = ['_ownAclItem', '_organizationAclItem', '_mostPrivilegedGroupAclItem'];

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  _organizationAclItem: function(m) {
    var org = _.result(m.collection, 'organization') || m.organization;
    if (org) {
      return this._ownAclItem(org);
    }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

  getUsersWithAnyPermission: function() {
    return this.acl.chain()
      .filter(this._hasTypeUser)
      .map(this._getEntity)
      .value();

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

  _mostPrivilegedGroupAclItem: function(m) {
    var groups = _.result(m.groups, 'models');
    if (groups) {
      return this._findMostPrivilegedAclItem(groups, this._ownAclItem);
    }

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

  revokeAccess: function(model) {
    var aclItem = this._ownAclItem(model);
    if (aclItem) {
      this.acl.remove(aclItem);
    }

• Read up
  Read up