Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js

Summary

Maintainability
D
2 days
Test Coverage

File basemap_dropdown.js has 292 lines of code (exceeds 250 allowed). Consider refactoring.
Open


/**
 * User options dropdown (extends Dropdown)
 *
 * It shows the content in a dropdown (or dropup) with a special effect.
Severity: Minor
Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js - About 3 hrs to fix

    DropdownBasemap has 23 functions (exceeds 20 allowed). Consider refactoring.
    Open

    cdb.admin.DropdownBasemap = cdb.ui.common.Dropdown.extend({

  className: 'dropdown basemap',

  // TODO: remove gmaps code from here
    Severity: Minor
    Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js - About 2 hrs to fix

      Function add has 49 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        add: function(lyr) {

    //if (!lyr.get("urlTemplate")) return;

    var v;
      Severity: Minor
      Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js - About 1 hr to fix

        Function add has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

          add: function(lyr) {

    //if (!lyr.get("urlTemplate")) return;

    var v;
        Severity: Minor
        Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function setActiveBaselayer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          setActiveBaselayer: function(layer) {

    for (var sv in this._subviews) {

      var subview = this._subviews[sv];
        Severity: Minor
        Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _updateTarget has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          _updateTarget: function(subview) {

    var className = subview.model.get("className");
    var type      = subview.model.get("type");
    var color     = subview.model.get("color");
        Severity: Minor
        Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

          hide: function(done) {

    if (!this.isOpen) {
      done && done();
      return;
        Severity: Major
        Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js and 5 other locations - About 5 hrs to fix
        lib/assets/javascripts/cartodb/table/map/map_options_dropdown.js on lines 244..266
        lib/assets/javascripts/cartodb/table/overlays/canvas_setup_dropdown.js on lines 110..131
        lib/assets/javascripts/cartodb/table/overlays/overlay_properties_dropdown.js on lines 260..281
        lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js on lines 182..203
        lib/assets/javascripts/cartodb/table/slides/transition_dropdown.js on lines 230..251

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 144.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 3 locations. Consider refactoring.
        Open

          clean: function() {
    $(document).unbind('keydown', this._keydown);
    cdb.ui.common.Dropdown.prototype.clean.call(this);
  }
        Severity: Major
        Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js and 2 other locations - About 1 hr to fix
        lib/assets/javascripts/cartodb/table/map/map_options_dropdown.js on lines 408..411
        lib/assets/javascripts/cartodb/table/overlays/canvas_setup_dropdown.js on lines 196..199

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 61.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            var view = new cdb.editor.AddCustomBasemapView({
      map: this.model,
      baseLayers: this.baseLayers,
      clean_on_hide: true,
      enter_to_confirm: true
        Severity: Minor
        Found in lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js and 1 other location - About 40 mins to fix
        lib/assets/javascripts/cartodb/table/row_header_dropdown.js on lines 89..94

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status