Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js

Summary

Maintainability
F
3 days
Test Coverage

File overlays_dropdown.js has 305 lines of code (exceeds 250 allowed). Consider refactoring.
Open

cdb.admin.OverlaysDropdownItem = cdb.core.View.extend({

  tagName: "li",

  events: {
Severity: Minor
Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js - About 3 hrs to fix

    Function _addTitleOverlay has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _addTitleOverlay: function() {

    var content = this.vis.get("name");
    var width   = 350;
    var height  = 30;
    Severity: Minor
    Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js - About 1 hr to fix

      Function _addImageOverlay has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _addImageOverlay: function() {

    var width  = 400;
    var height = 200;
      Severity: Minor
      Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js - About 1 hr to fix

        Function _addTextOverlay has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _addTextOverlay: function() {

    var width  = 200;
    var height = 30;
        Severity: Minor
        Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js - About 1 hr to fix

          Function _addAnnotationOverlay has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            _addAnnotationOverlay: function() {

    var defaultStyle = {
      "z-index":          4,
      "color":            "#ffffff",
          Severity: Minor
          Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js - About 1 hr to fix

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

              show: function() {

    var dfd = $.Deferred();
    var self = this;
            Severity: Major
            Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js and 2 other locations - About 6 hrs to fix
            lib/assets/javascripts/cartodb/table/overlays/canvas_setup_dropdown.js on lines 49..76
            lib/assets/javascripts/cartodb/table/slides/transition_dropdown.js on lines 161..188

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 158.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 6 locations. Consider refactoring.
            Open

              hide: function(done) {

    if (!this.isOpen) {
      done && done();
      return;
            Severity: Major
            Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js and 5 other locations - About 5 hrs to fix
            lib/assets/javascripts/cartodb/table/basemap/basemap_dropdown/basemap_dropdown.js on lines 365..386
            lib/assets/javascripts/cartodb/table/map/map_options_dropdown.js on lines 244..266
            lib/assets/javascripts/cartodb/table/overlays/canvas_setup_dropdown.js on lines 110..131
            lib/assets/javascripts/cartodb/table/overlays/overlay_properties_dropdown.js on lines 260..281
            lib/assets/javascripts/cartodb/table/slides/transition_dropdown.js on lines 230..251

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 144.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 5 locations. Consider refactoring.
            Open

              _recalcHeight: function() {

    var $ul  = this.$el.find("ul.special");

    // Resets heights
            Severity: Major
            Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js and 4 other locations - About 5 hrs to fix
            lib/assets/javascripts/cartodb/table/map/map_options_dropdown.js on lines 268..283
            lib/assets/javascripts/cartodb/table/overlays/canvas_setup_dropdown.js on lines 133..148
            lib/assets/javascripts/cartodb/table/overlays/overlay_properties_dropdown.js on lines 283..298
            lib/assets/javascripts/cartodb/table/slides/transition_dropdown.js on lines 253..268

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 140.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                this.$el.css({
      top: 40,
      left: 0
    })
    .addClass(
            Severity: Major
            Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js and 1 other location - About 3 hrs to fix
            lib/assets/javascripts/cartodb/table/overlays/canvas_setup_dropdown.js on lines 87..99

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 104.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 4 locations. Consider refactoring.
            Open

              _handleClick: function(ev) {
    if (ev) {
      ev.preventDefault();
    }
            Severity: Major
            Found in lib/assets/javascripts/cartodb/table/overlays/overlays_dropdown.js and 3 other locations - About 1 hr to fix
            lib/assets/javascripts/cartodb/table/overlays/canvas_setup_dropdown.js on lines 36..47
            lib/assets/javascripts/cartodb/table/overlays/overlay_properties_dropdown.js on lines 41..52
            lib/assets/javascripts/cartodb/table/slides/transition_dropdown.js on lines 96..107

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 69.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status