Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/cartodb/table/table_editor_view.js

Summary

Maintainability
D
2 days
Test Coverage

File table_editor_view.js has 346 lines of code (exceeds 250 allowed). Consider refactoring.
Open

cdb.admin.TableEditorView = cdb.core.View.extend({

  el: document.body,

  events: {
Severity: Minor
Found in lib/assets/javascripts/cartodb/table/table_editor_view.js - About 4 hrs to fix

    Function _initViews has 97 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _initViews: function() {
    this.globalError = new cdb.admin.GlobalError({
      el: $('.globalerror')
    });
    this.globalError.listenGlobal();
    Severity: Major
    Found in lib/assets/javascripts/cartodb/table/table_editor_view.js - About 3 hrs to fix

      Function _initModels has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _initModels: function() {
    var self = this;
    this.vis = new cdb.admin.Visualization(this.options.vis_data);
      // when the user changes slides the visualization is changed
      // but we want to keep the master one for tasks that require to use it
      Severity: Major
      Found in lib/assets/javascripts/cartodb/table/table_editor_view.js - About 2 hrs to fix

        Function _initTableMap has 50 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          _initTableMap: function() {
    var self = this;


    // Init geocoder
        Severity: Minor
        Found in lib/assets/javascripts/cartodb/table/table_editor_view.js - About 2 hrs to fix

          Function _initViews has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
          Open

            _initViews: function() {
    this.globalError = new cdb.admin.GlobalError({
      el: $('.globalerror')
    });
    this.globalError.listenGlobal();
          Severity: Minor
          Found in lib/assets/javascripts/cartodb/table/table_editor_view.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              this.mapTab = new cdb.admin.MapTab({
      model: this.map,
      authTokens: this.authTokens,
      baseLayers: this.baseLayers,
      vis: this.vis,
          Severity: Major
          Found in lib/assets/javascripts/cartodb/table/table_editor_view.js and 1 other location - About 2 hrs to fix
          lib/assets/javascripts/builder/components/modals/publish/share/share-permission-view.js on lines 51..62

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 93.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              cdb.god.bind('dialogOpened', function() {
      if (this.vis.isVisualization() && this.mamufasView) {
        this.mamufasView.disable();
      }
      this.backgroundPollingModel && this.backgroundPollingModel.stopPollings();
          Severity: Major
          Found in lib/assets/javascripts/cartodb/table/table_editor_view.js and 1 other location - About 2 hrs to fix
          lib/assets/javascripts/cartodb/table/table_editor_view.js on lines 352..357

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              cdb.god.bind('dialogClosed', function() {
      if (this.vis.isVisualization() && this.mamufasView) {
        this.mamufasView.enable();
      }
      this.backgroundPollingModel && this.backgroundPollingModel.startPollings();
          Severity: Major
          Found in lib/assets/javascripts/cartodb/table/table_editor_view.js and 1 other location - About 2 hrs to fix
          lib/assets/javascripts/cartodb/table/table_editor_view.js on lines 346..351

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 84.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                var viewModel = new cdb.editor.ChangeLockViewModel({
        items: [this.vis],
        contentType: this.vis.isVisualization() ? 'maps' : 'datasets'
      });
          Severity: Minor
          Found in lib/assets/javascripts/cartodb/table/table_editor_view.js and 1 other location - About 55 mins to fix
          lib/assets/javascripts/cartodb/table/header/options_menu.js on lines 97..100

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if (this.player.hasVideoData()) {
      this.$el.append(this.player.render().$el);
    }
          Severity: Minor
          Found in lib/assets/javascripts/cartodb/table/table_editor_view.js and 1 other location - About 40 mins to fix
          lib/assets/javascripts/builder/components/modals/add-layer/content/datasets/datasets-pagination-view.js on lines 35..37

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status