Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/dashboard/data/table/row-model.js

Summary

Maintainability
D
1 day
Test Coverage

Function fetch has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  fetch: function (opts) {
    opts = opts || {};
    var username = (this.options && this.options.user_data) ? this.options.user_data.username
      : (window.user_data ? window.user_data.username : window.user_name);
    var api_key = (this.options && this.options.user_data) ? this.options.user_data.api_key
Severity: Minor
Found in lib/assets/javascripts/dashboard/data/table/row-model.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fetch has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  fetch: function (opts) {
    opts = opts || {};
    var username = (this.options && this.options.user_data) ? this.options.user_data.username
      : (window.user_data ? window.user_data.username : window.user_name);
    var api_key = (this.options && this.options.user_data) ? this.options.user_data.api_key
Severity: Minor
Found in lib/assets/javascripts/dashboard/data/table/row-model.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

          return false;
    Severity: Major
    Found in lib/assets/javascripts/dashboard/data/table/row-model.js - About 30 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        url: function (method) {
    var version = this._configModel.urlVersion('record', method);
    var table = this.table || this.collection.table;
    if (!table) {
      console.error('row has no table assigned');
      Severity: Major
      Found in lib/assets/javascripts/dashboard/data/table/row-model.js and 1 other location - About 4 hrs to fix
      lib/assets/javascripts/dashboard/data/table/column-model.js on lines 13..25

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 133.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        toJSON: function () {
    var attr = _.clone(this.attributes);
    // remove read-only attributes
    delete attr['updated_at'];
    delete attr['created_at'];
      Severity: Major
      Found in lib/assets/javascripts/dashboard/data/table/row-model.js and 1 other location - About 2 hrs to fix
      lib/assets/javascripts/cartodb/models/table.js on lines 992..1002

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

          var username = (this.options && this.options.user_data) ? this.options.user_data.username
      : (window.user_data ? window.user_data.username : window.user_name);
      Severity: Major
      Found in lib/assets/javascripts/dashboard/data/table/row-model.js and 9 other locations - About 1 hr to fix
      lib/assets/javascripts/cartodb/models/table.js on lines 8..9
      lib/assets/javascripts/cartodb/models/table.js on lines 10..11
      lib/assets/javascripts/cartodb/models/table.js on lines 690..691
      lib/assets/javascripts/cartodb/models/table.js on lines 692..693
      lib/assets/javascripts/cartodb/models/table.js on lines 949..950
      lib/assets/javascripts/cartodb/models/table.js on lines 951..952
      lib/assets/javascripts/dashboard/data/table/row-model.js on lines 46..47
      lib/assets/javascripts/dashboard/views/public-dataset/carto-table-metadata.js on lines 647..648
      lib/assets/javascripts/dashboard/views/public-dataset/carto-table-metadata.js on lines 649..650

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

          var api_key = (this.options && this.options.user_data) ? this.options.user_data.api_key
      : (window.user_data ? window.user_data.api_key : window.api_key);
      Severity: Major
      Found in lib/assets/javascripts/dashboard/data/table/row-model.js and 9 other locations - About 1 hr to fix
      lib/assets/javascripts/cartodb/models/table.js on lines 8..9
      lib/assets/javascripts/cartodb/models/table.js on lines 10..11
      lib/assets/javascripts/cartodb/models/table.js on lines 690..691
      lib/assets/javascripts/cartodb/models/table.js on lines 692..693
      lib/assets/javascripts/cartodb/models/table.js on lines 949..950
      lib/assets/javascripts/cartodb/models/table.js on lines 951..952
      lib/assets/javascripts/dashboard/data/table/row-model.js on lines 44..45
      lib/assets/javascripts/dashboard/views/public-dataset/carto-table-metadata.js on lines 647..648
      lib/assets/javascripts/dashboard/views/public-dataset/carto-table-metadata.js on lines 649..650

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (opts.no_geom) {
      columns = _.without(columns, 'the_geom', 'the_geom_webmercator');
    } else {
      columns = _.without(columns, 'the_geom');
    }
      Severity: Minor
      Found in lib/assets/javascripts/dashboard/data/table/row-model.js and 1 other location - About 40 mins to fix
      lib/assets/javascripts/cartodb/models/table.js on lines 966..970

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 48.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if (the_geom && typeof the_geom === 'object') {
      return !!the_geom.coordinates;
    } else if (typeof the_geom !== 'string') {
      return false;
    }
      Severity: Minor
      Found in lib/assets/javascripts/dashboard/data/table/row-model.js and 1 other location - About 35 mins to fix
      lib/assets/javascripts/cartodb/models/table.js on lines 1039..1043

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status