CartoDB/cartodb20

View on GitHub
lib/assets/javascripts/dashboard/statics/static.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function addAssets has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var addAssets = function (options) {
    (function (w, d, a, favicon, stylesheets, scripts, l, h, s, t) {
      var googleMapsQueryString = w.CartoConfig.vizdata
        ? w.CartoConfig.vizdata.user.google_maps_query_string
        : null;
Severity: Minor
Found in lib/assets/javascripts/dashboard/statics/static.js - About 1 hr to fix

    Function getUserConfig has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var getUserConfig = function (visualizationError) {
        client.getConfig(function (err, response, data) {
          if (err) {
            if (data.responseJSON && data.responseJSON.error === 'maintenance_mode') {
              var baseURL = Redirector.getBaseUrl(window.location);
    Severity: Minor
    Found in lib/assets/javascripts/dashboard/statics/static.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return redirectTo(userData.base_url + '/' + window.StaticConfig.page);
      Severity: Major
      Found in lib/assets/javascripts/dashboard/statics/static.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return redirectToUnverified(userData.base_url);
        Severity: Major
        Found in lib/assets/javascripts/dashboard/statics/static.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return redirectToMultifactorAuthentication();
          Severity: Major
          Found in lib/assets/javascripts/dashboard/statics/static.js - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status