Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js

Summary

Maintainability
F
6 days
Test Coverage

exports has 37 functions (exceeds 20 allowed). Consider refactoring.
Open

module.exports = Table.extend({

  classLabel: 'cdb.admin.TableView',

  events: CoreView.extendEvents({
Severity: Minor
Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 4 hrs to fix

    File table-view.js has 345 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    const $ = require('jquery');
const _ = require('underscore');
const CoreView = require('backbone/core-view');
const Table = require('dashboard/components/table/table');
const templateSQLViewNotice = require('./sql-view-notice.tpl');
    Severity: Minor
    Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 4 hrs to fix

      Function initPaginationAndScroll has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
      Open

        initPaginationAndScroll: function () {
    var topReached = false;
    var bottomReached = false;

    // Initialize moving header and loaders when scrolls
      Severity: Minor
      Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function initPaginationAndScroll has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        initPaginationAndScroll: function () {
    var topReached = false;
    var bottomReached = false;

    // Initialize moving header and loaders when scrolls
      Severity: Minor
      Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 1 hr to fix

        Function checkScrollTimer has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            this.checkScrollTimer = setInterval(() => {
      if (!this.$el.is(':visible') || this.model.data().isFetchingPage()) {
        return;
      }
      var pos = $(this).scrollTop();
        Severity: Minor
        Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 1 hr to fix

          Function _moveInfo has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            _moveInfo: function (type) {
    if (type == 'show') { // eslint-disable-line eqeqeq
      this.$el
        .removeClass('narrow')
        .addClass('displaced');
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _setUpPagination has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

            _setUpPagination: function (d) {
    var pages = d.pages;

    // Check if the table is not in the first page
    if (pages.length > 0 && pages[0] > 0) {
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _scrollMagic has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            _scrollMagic: function (ev) {
    var actual_scroll_position = { x: $(window).scrollLeft(), y: $(window).scrollTop() };

    if (this.scroll_position.x != actual_scroll_position.x) { // eslint-disable-line eqeqeq
      this.scroll_position.x = actual_scroll_position.x;
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _highlightColumn: function () {
    if (this.newColumnName) {
      var $th = this.$("a[href='#" + this.newColumnName + "']").parents('th');
      var position = $th.index();
          Severity: Major
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 1 day to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 185..206

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 226.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            _onSQLView: function () {
    // bind each time we change dataSource because table unbind
    // all the events from sqlView object each time useSQLView is called
    this.$('.sqlview').remove();
          Severity: Major
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 6 hrs to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 270..282

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 166.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            addColumn: function (column) {
    this.newColumnName = 'column_' + new Date().getTime();

    this.model.addColumn(this.newColumnName, 'string');
          Severity: Major
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 2 hrs to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 176..183

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            cleanEmptyTableInfo: function () {
    this.$('tfoot').fadeOut('fast', function () {
      $(this).remove();
    });
    this.$('.noRows').slideUp('fast', function () {
          Severity: Major
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 2 hrs to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 670..677

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 90.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            _swicthEnabled: function () {
    // Synced?
    this.$el[ this.model.isSync() ? 'addClass' : 'removeClass' ]('synced');
    // Visualization?
    this.$el[ this.vis.isVisualization() ? 'addClass' : 'removeClass' ]('vis');
          Severity: Major
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 2 hrs to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 315..320

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            needsRender: function (table) {
    if (!table) return true;
    var ca = table.changedAttributes();
    if (ca.geometry_types && _.keys(ca).length === 1) {
      return false;
          Severity: Major
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 1 hr to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 150..157

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 71.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              this.scroll_position = { x: $(window).scrollLeft(), y: $(window).scrollTop(), last: 'vertical' };
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 50 mins to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 88..88

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 51.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _checkEmptyTable: function () {
    if (this.isEmptyTable()) {
      this.addEmptyTableInfo();
    } else {
      this.cleanEmptyTableInfo();
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 45 mins to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 579..585

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 50.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 5 locations. Consider refactoring.
          Open

            closeEditor: function () {
    if (this._editorsOpened) {
      this._editorsOpened.hide();
      this._editorsOpened.clean();
    }
          Severity: Major
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 4 other locations - About 40 mins to fix
          lib/assets/javascripts/builder/components/form-components/editors/datetime/datetime.js on lines 86..91
          lib/assets/javascripts/builder/components/form-components/field.js on lines 108..113
          lib/assets/javascripts/builder/components/modals/publish/share/share-permission-view.js on lines 130..135
          lib/assets/javascripts/cartodb/table/tableview.js on lines 426..431

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  this.$el.find('thead > tr > th > div > div:not(.dropdown)')
          .removeAttr('style')
          .css({'marginLeft': '-' + actual_scroll_position.x + 'px'});
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 40 mins to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 368..370

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            _clearView: function (e) {
    if (e) e.preventDefault();
    this.options.layer.clearSQLView();
    return false;
  },
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 35 mins to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 322..326

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            _startPagination: function (updown) {
    // Loader... move on buddy!
    this.$el.find('.page_loader.' + updown + '').addClass('active');
  },
          Severity: Minor
          Found in lib/assets/javascripts/dashboard/views/public-dataset/table-view/table-view.js and 1 other location - About 35 mins to fix
          lib/assets/javascripts/cartodb/table/tableview.js on lines 247..250

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status