Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/assets/javascripts/new-dashboard/core/dialog-actions.js

Summary

Maintainability
F
3 days
Test Coverage

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export function deleteVisualization (visualization, contentType, actionHandlers) {
  const dialogProps = { visualization, contentType };
  this.showModal(
    {
      template: `
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 3 other locations - About 3 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 132..154
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 156..178
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 203..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export function changeVisualizationsLockState (visualizations, contentType, actionHandlers) {
  const dialogProps = { visualizations, contentType };

  this.showModal(
    {
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 3 other locations - About 3 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 132..154
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 180..201
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 203..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export function deleteVisualizations (visualizations, contentType, actionHandlers) {
  const dialogProps = { visualizations, contentType };
  this.showModal(
    {
      template: `
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 3 other locations - About 3 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 132..154
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 156..178
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 180..201

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

export function changeLockState (visualization, contentType, actionHandlers) {
  const dialogProps = { visualization, contentType };

  this.showModal(
    {
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 3 other locations - About 3 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 156..178
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 180..201
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 203..224

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 103.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export function editMapMetadata (visualization, actionHandlers) {
  this.showModal(
    {
      template: `
      <Dialog v-on:close="$emit('close')">
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 4 other locations - About 2 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 36..54
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 74..94
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 96..116
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 244..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export function shareViaUrl (visualization, actionHandlers) {
  this.showModal(
    {
      template: `
      <Dialog v-on:close="$emit('close')">
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 4 other locations - About 2 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 14..34
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 36..54
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 74..94
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 96..116

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export function editDatasetMetadata (dataset, actionHandlers) {
  this.showModal(
    {
      template: `
        <DatasetMetadata
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 4 other locations - About 2 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 14..34
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 74..94
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 96..116
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 244..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export function changePrivacy (visualization, actionHandlers) {
  this.showModal(
    {
      template: `
      <Dialog @close="$emit('close')">
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 4 other locations - About 2 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 14..34
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 36..54
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 96..116
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 244..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

export function shareVisualization (visualization, actionHandlers) {
  this.showModal(
    {
      template: `
      <Dialog v-on:close="$emit('close')">
Severity: Major
Found in lib/assets/javascripts/new-dashboard/core/dialog-actions.js and 4 other locations - About 2 hrs to fix
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 14..34
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 36..54
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 74..94
lib/assets/javascripts/new-dashboard/core/dialog-actions.js on lines 244..264

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 89.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status