CartoDB/cartodb20

View on GitHub
lib/assets/javascripts/utils/postgres.codemirror.js

Summary

Maintainability
D
1 day
Test Coverage

Function tokenBase has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function tokenBase(stream, state) {
    var ch = stream.next();
    curPunc = null;
    if (ch == "$" || ch == "?") {
      stream.match(/^[\w\d]*/);
Severity: Minor
Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 2 hrs to fix

    Function token has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        token: function(stream, state) {
          if (stream.sol()) {
            if (state.context && state.context.align == null) state.context.align = false;
            state.indent = stream.indentation();
          }
    Severity: Minor
    Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return "atom";
      Severity: Major
      Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return "keyword";
        Severity: Major
        Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return null;
          Severity: Major
          Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return null;
            Severity: Major
            Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return null;
              Severity: Major
              Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return "atom";
                Severity: Major
                Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return "comment";
                  Severity: Major
                  Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return "variable";
                    Severity: Major
                    Found in lib/assets/javascripts/utils/postgres.codemirror.js - About 30 mins to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        function tokenLiteral(quote) {
                          return function(stream, state) {
                            var escaped = false, ch;
                            while ((ch = stream.next()) != null) {
                              if (ch == quote && !escaped) {
                      Severity: Major
                      Found in lib/assets/javascripts/utils/postgres.codemirror.js and 1 other location - About 3 hrs to fix
                      lib/assets/javascripts/utils/postgres.codemirror.js on lines 109..121

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 100.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        function tokenOpLiteral(quote) {
                          return function(stream, state) {
                            var escaped = false, ch;
                            while ((ch = stream.next()) != null) {
                              if (ch == quote && !escaped) {
                      Severity: Major
                      Found in lib/assets/javascripts/utils/postgres.codemirror.js and 1 other location - About 3 hrs to fix
                      lib/assets/javascripts/utils/postgres.codemirror.js on lines 95..107

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 100.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 2 locations. Consider refactoring.
                      Open

                        function popContext(state) {
                          state.indent = state.context.indent;
                          state.context = state.context.prev;
                        }
                      Severity: Minor
                      Found in lib/assets/javascripts/utils/postgres.codemirror.js and 1 other location - About 35 mins to fix
                      lib/assets/javascripts/builder/components/code-mirror/mode/sql.js on lines 152..155

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 47.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status