Sign upLogin

CartoDB/cartodb20

View on GitHub
Star
lib/build/branchFiles/modifiedFiles.js

Summary

Maintainability
C
1 day
Test Coverage

Function getFilesInStatus has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

function getFilesInStatus () {
  var promise = new Promise(function (resolve, reject) {
    child.exec('git status --short', function (error, stdout, stderr) {
      if (!error) {
        var newLine = /\n/;
Severity: Minor
Found in lib/build/branchFiles/modifiedFiles.js - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getFilesInStatus has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getFilesInStatus () {
  var promise = new Promise(function (resolve, reject) {
    child.exec('git status --short', function (error, stdout, stderr) {
      if (!error) {
        var newLine = /\n/;
Severity: Minor
Found in lib/build/branchFiles/modifiedFiles.js - About 1 hr to fix

    Function promise has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      var promise = new Promise(function (resolve, reject) {
    child.exec('git status --short', function (error, stdout, stderr) {
      if (!error) {
        var newLine = /\n/;
        var files = stdout.split(newLine);
    Severity: Minor
    Found in lib/build/branchFiles/modifiedFiles.js - About 1 hr to fix

      Function promises has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              var promises = files.reduce(function (acc, file) {
          if (file.trim().length > 0) {
            var name = file.slice(3);
            var resolvedPath = path.resolve('.', name);
      Severity: Minor
      Found in lib/build/branchFiles/modifiedFiles.js - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status