Sign upLogin

Cellarise/loopback-connector-sendgrid

View on GitHub
Star
tasks/lib/coverageStats.js

Summary

Maintainability
F
3 days
Test Coverage

Function coverageStats has a Cognitive Complexity of 51 (exceeds 5 allowed). Consider refactoring.
Open

module.exports = function coverageStats(logger) {

  var exports = {

    /**
Severity: Minor
Found in tasks/lib/coverageStats.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function coverageStats has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function coverageStats(logger) {

  var exports = {

    /**
Severity: Major
Found in tasks/lib/coverageStats.js - About 4 hrs to fix

    Function calculateCoverageStats has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        "calculateCoverageStats": function calculateCoverageStats(coverageReport, packageJSON) {
      var coverageStat = {
        "lines": {"total": 0, "covered": 0, "skipped": 0},
        "branches": {"total": 0, "covered": 0, "skipped": 0},
        "statements": {"total": 0, "covered": 0, "skipped": 0},
    Severity: Major
    Found in tasks/lib/coverageStats.js - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

            if (coverageReport && packageJSON) {
        for (coveredFile in coverageReport) {
          if (coverageReport.hasOwnProperty(coveredFile)) {
            this.addStats(coverageStat, coverageReport[coveredFile]);
          }
      Severity: Critical
      Found in tasks/lib/coverageStats.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                coverageStat.overall.pct =
          Math.round((coverageStat.lines.pct +
          coverageStat.branches.pct +
          coverageStat.statements.pct +
          coverageStat.functions.pct) / 400 * 100);
        Severity: Major
        Found in tasks/lib/coverageStats.js and 1 other location - About 2 hrs to fix
        tasks/lib/coverageStats.js on lines 113..116

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                coverageStat.skipped.pct = Math.round((coverageStat.lines.pctSkipped +
        coverageStat.branches.pctSkipped +
        coverageStat.statements.pctSkipped +
        coverageStat.functions.pctSkipped) / 400 * 100);
        Severity: Major
        Found in tasks/lib/coverageStats.js and 1 other location - About 2 hrs to fix
        tasks/lib/coverageStats.js on lines 127..131

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                coverageStat.lines.pctSkipped =
          Math.round(coverageStat.lines.skipped / coverageStat.lines.total * 100) || 0;
        Severity: Minor
        Found in tasks/lib/coverageStats.js and 1 other location - About 55 mins to fix
        tasks/lib/coverageStats.js on lines 119..120

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                coverageStat.lines.pct =
          Math.round(coverageStat.lines.covered / coverageStat.lines.total * 100) || 100;
        Severity: Minor
        Found in tasks/lib/coverageStats.js and 1 other location - About 55 mins to fix
        tasks/lib/coverageStats.js on lines 104..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                coverageStat.branches.pct =
          Math.round(coverageStat.branches.covered / coverageStat.branches.total * 100) || 100;
        Severity: Major
        Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
        tasks/lib/coverageStats.js on lines 106..107
        tasks/lib/coverageStats.js on lines 108..109
        tasks/lib/coverageStats.js on lines 110..111
        tasks/lib/coverageStats.js on lines 123..124
        tasks/lib/coverageStats.js on lines 125..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                coverageStat.statements.pctSkipped =
          Math.round(coverageStat.statements.skipped / coverageStat.statements.total * 100) || 0;
        Severity: Major
        Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
        tasks/lib/coverageStats.js on lines 106..107
        tasks/lib/coverageStats.js on lines 110..111
        tasks/lib/coverageStats.js on lines 121..122
        tasks/lib/coverageStats.js on lines 123..124
        tasks/lib/coverageStats.js on lines 125..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                coverageStat.branches.pctSkipped =
          Math.round(coverageStat.branches.skipped / coverageStat.branches.total * 100) || 0;
        Severity: Major
        Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
        tasks/lib/coverageStats.js on lines 108..109
        tasks/lib/coverageStats.js on lines 110..111
        tasks/lib/coverageStats.js on lines 121..122
        tasks/lib/coverageStats.js on lines 123..124
        tasks/lib/coverageStats.js on lines 125..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                coverageStat.functions.pctSkipped =
          Math.round(coverageStat.functions.skipped / coverageStat.functions.total * 100) || 0;
        Severity: Major
        Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
        tasks/lib/coverageStats.js on lines 106..107
        tasks/lib/coverageStats.js on lines 108..109
        tasks/lib/coverageStats.js on lines 121..122
        tasks/lib/coverageStats.js on lines 123..124
        tasks/lib/coverageStats.js on lines 125..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                coverageStat.functions.pct =
          Math.round(coverageStat.functions.covered / coverageStat.functions.total * 100) || 100;
        Severity: Major
        Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
        tasks/lib/coverageStats.js on lines 106..107
        tasks/lib/coverageStats.js on lines 108..109
        tasks/lib/coverageStats.js on lines 110..111
        tasks/lib/coverageStats.js on lines 121..122
        tasks/lib/coverageStats.js on lines 123..124

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 6 locations. Consider refactoring.
        Open

                coverageStat.statements.pct =
          Math.round(coverageStat.statements.covered / coverageStat.statements.total * 100) || 100;
        Severity: Major
        Found in tasks/lib/coverageStats.js and 5 other locations - About 50 mins to fix
        tasks/lib/coverageStats.js on lines 106..107
        tasks/lib/coverageStats.js on lines 108..109
        tasks/lib/coverageStats.js on lines 110..111
        tasks/lib/coverageStats.js on lines 121..122
        tasks/lib/coverageStats.js on lines 125..126

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 51.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status