Sign upLogin

ChiefOfGxBxL/WC3MapTranslator

View on GitHub
Star

Showing 25 of 40 total issues

Function jsonToWar has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static jsonToWar(doodadsJson: Doodad[]): WarResult {
        const outBufferToWar = new HexBuffer();
        /*
         * Header
         */
Severity: Minor
Found in src/translators/DoodadsTranslator.ts - About 1 hr to fix

    Function jsonToWar has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static jsonToWar(regionsJson: Region[]): WarResult {
        const outBufferToWar = new HexBuffer();

        /*
         * Header
    Severity: Minor
    Found in src/translators/RegionsTranslator.ts - About 1 hr to fix

      Function warToJson has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static warToJson(buffer: Buffer): JsonResult<Doodad[]> {
        const result = [];
        const outBufferToJSON = new W3Buffer(buffer);

        const fileId = outBufferToJSON.readChars(4); // W3do for doodad file
      Severity: Minor
      Found in src/translators/DoodadsTranslator.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Consider simplifying this complex logical expression.
      Open

                          if (type === ObjectType.Doodads || type === ObjectType.Abilities || type === ObjectType.Upgrades) {

                        // Level or variation
                        // We need to check if hasOwnProperty because these could be explititly
                        // set to 0, but JavaScript's truthiness evaluates to false to it was defaulting
      Severity: Major
      Found in src/translators/ObjectsTranslator.ts - About 40 mins to fix

        Function jsonToWar has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public static jsonToWar(terrainJson: Terrain): WarResult {
        const outBufferToWar = new HexBuffer();

        /*
         * Header
        Severity: Minor
        Found in src/translators/TerrainTranslator.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language