Sign upLogin

CleverStack/clever-roles

View on GitHub
Star
services/RoleService.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function exports has 66 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(Promise, Service, RoleModel, PermissionService, underscore, async) {
  var debug = require('debug')('cleverstack:services:RoleService');
  
  return Service.extend({
    model: RoleModel,
Severity: Major
Found in services/RoleService.js - About 2 hrs to fix

    Function AccountModel afterCreate has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        'AccountModel afterCreate': function(account, values, queryOptions, callback) {
      Promise.all([
        this.findDefaultRoles(queryOptions),
        PermissionService.createAccountDefaultPermissions(account, values, queryOptions)
      ])
    Severity: Major
    Found in services/RoleService.js - About 2 hrs to fix

      Function exports has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

      module.exports = function(Promise, Service, RoleModel, PermissionService, underscore, async) {
  var debug = require('debug')('cleverstack:services:RoleService');
  
  return Service.extend({
    model: RoleModel,
      Severity: Minor
      Found in services/RoleService.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function exports has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      module.exports = function(Promise, Service, RoleModel, PermissionService, underscore, async) {
      Severity: Minor
      Found in services/RoleService.js - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status