Cloud-CV/EvalAI

View on GitHub
frontend/src/js/controllers/analyticsCtrl.js

Summary

Maintainability
F
4 days
Test Coverage

Function AnalyticsCtrl has 224 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function AnalyticsCtrl(utilities, $state, $rootScope) {
        var vm = this;

        vm.hostTeam = {};
        vm.teamId = null;
Severity: Major
Found in frontend/src/js/controllers/analyticsCtrl.js - About 1 day to fix

    Function showChallengeAnalysis has 134 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            vm.showChallengeAnalysis = function() {
                if (vm.challengeId != null) {
                    parameters.url = 'challenges/challenge/' + vm.challengeId + '/challenge_phase';
                    parameters.method = 'GET';
                    parameters.token = userKey;
    Severity: Major
    Found in frontend/src/js/controllers/analyticsCtrl.js - About 5 hrs to fix

      Function onSuccess has 103 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                          onSuccess: function(response) {
                              var status = response.status;
                              var details = response.data;
                              parameters.url = 'analytics/challenge/' + vm.challengeId + '/team/count';
                              parameters.method = 'GET';
      Severity: Major
      Found in frontend/src/js/controllers/analyticsCtrl.js - About 4 hrs to fix

        Avoid deeply nested control flow statements.
        Open

                                                    for(var i=0; i<challengePhaseId.length; i++) {
                                                        if (challengePhaseId[i] == details.challenge_phase) {
                                                            vm.totalSubmission[challengePhaseId[i]] = details.total_submissions;
                                                            vm.totalParticipatedTeams[challengePhaseId[i]] = details.participant_team_count;
                                                            i++;
        Severity: Major
        Found in frontend/src/js/controllers/analyticsCtrl.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                                      for(var i=0; i<challengePhaseId.length; i++) {
                                                          if (challengePhaseId[i] == response.data.challenge_phase) {
                                                              vm.lastSubmissionTime[challengePhaseId[i]] = details.last_submission_timestamp_in_challenge_phase;
                                                              i++;
                                                              break;
          Severity: Major
          Found in frontend/src/js/controllers/analyticsCtrl.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    parameters.callback = {
                        onSuccess: function(response) {
                            var status = response.status;
                            var details = response.data;
                            if (status == 200) {
            Severity: Major
            Found in frontend/src/js/controllers/analyticsCtrl.js and 1 other location - About 7 hrs to fix
            frontend/src/js/controllers/analyticsCtrl.js on lines 107..131

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 192.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    parameters.callback = {
                                        onSuccess: function(response) {
                                            var status = response.status;
                                            var details = response.data;
                                            if (status == 200) {
            Severity: Major
            Found in frontend/src/js/controllers/analyticsCtrl.js and 1 other location - About 7 hrs to fix
            frontend/src/js/controllers/analyticsCtrl.js on lines 35..60

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 192.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status