Sign upLogin

Cloud-CV/EvalAI

View on GitHub
Star
frontend/src/js/controllers/featuredChallengeCtrl.js

Summary

Maintainability
F
6 days
Test Coverage

Function FeaturedChallengeCtrl has 167 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function FeaturedChallengeCtrl(utilities, loaderService, $state, $stateParams, moment) {
        var vm = this;
        vm.challengeId = $stateParams.challengeId;
        vm.phaseSplitId = $stateParams.phaseSplitId;
        vm.phaseId = null;
Severity: Major
Found in frontend/src/js/controllers/featuredChallengeCtrl.js - About 6 hrs to fix

    Function getLeaderboard has 84 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            vm.getLeaderboard = function(phaseSplitId) {
            vm.isResult = true;
            vm.phaseSplitId = phaseSplitId;
            // loader for existing teams
            vm.isExistLoader = true;
    Severity: Major
    Found in frontend/src/js/controllers/featuredChallengeCtrl.js - About 3 hrs to fix

      Function onSuccess has 63 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                      onSuccess: function(response) {
                    var details = response.data;
                    vm.leaderboard = details.results;
                    for (var i=0; i<vm.leaderboard.length; i++) {
                        var dateTimeNow = moment(new Date());
      Severity: Major
      Found in frontend/src/js/controllers/featuredChallengeCtrl.js - About 2 hrs to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (days.toFixed(0)==1) {
                                vm.leaderboard[i].timeSpan = 'day';
                            } else {
                                vm.leaderboard[i].timeSpan = 'days';
                            }
        Severity: Major
        Found in frontend/src/js/controllers/featuredChallengeCtrl.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  else if (duration._data.hours !=0) {
                            var hours = duration.asHours();
                            vm.leaderboard[i].submission__submitted_at = hours;
                            if (hours.toFixed(0)==1) {
                                vm.leaderboard[i].timeSpan = 'hour';
          Severity: Major
          Found in frontend/src/js/controllers/featuredChallengeCtrl.js - About 45 mins to fix

            Function FeaturedChallengeCtrl has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function FeaturedChallengeCtrl(utilities, loaderService, $state, $stateParams, moment) {
            Severity: Minor
            Found in frontend/src/js/controllers/featuredChallengeCtrl.js - About 35 mins to fix

              Identical blocks of code found in 3 locations. Consider refactoring.
              Open

                                      if (duration._data.years != 0) {
                            var years = duration.asYears();
                            vm.leaderboard[i].submission__submitted_at = years;
                            if (years.toFixed(0)==1) {
                                vm.leaderboard[i].timeSpan = 'year';
              Severity: Major
              Found in frontend/src/js/controllers/featuredChallengeCtrl.js and 2 other locations - About 4 days to fix
              frontend/src/js/controllers/challengeCtrl.js on lines 1113..1166
              frontend/src/js/controllers/challengeCtrl.js on lines 1597..1645

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 683.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      parameters.callback = {
            onSuccess: function(response) {
                var details = response.data;
                vm.phaseSplits = details;
                utilities.hideLoader();
              Severity: Major
              Found in frontend/src/js/controllers/featuredChallengeCtrl.js and 1 other location - About 3 hrs to fix
              frontend/src/js/controllers/challengeCtrl.js on lines 2822..2834

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 114.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 4 locations. Consider refactoring.
              Open

                              onError: function(response) {
                    var error = response.data;
                    vm.leaderboard.error = error;
                    vm.stopLoader();
                }
              Severity: Major
              Found in frontend/src/js/controllers/featuredChallengeCtrl.js and 3 other locations - About 35 mins to fix
              frontend/src/js/controllers/challengeCtrl.js on lines 1173..1177
              frontend/src/js/controllers/challengeCtrl.js on lines 1532..1536
              frontend/src/js/controllers/challengeCtrl.js on lines 1652..1656

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 47.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status