Sign upLogin

Cloud-CV/EvalAI

View on GitHub
Star
frontend/src/js/controllers/profileCtrl.js

Summary

Maintainability
F
5 days
Test Coverage

Function profileCtrl has 316 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function profileCtrl(utilities, $rootScope, $scope, $mdDialog, moment, $state) {
        var vm = this;

        vm.user = {};
        vm.countLeft = 0;
Severity: Major
Found in frontend/src/js/controllers/profileCtrl.js - About 1 day to fix

    File profileCtrl.js has 325 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Invoking IIFE for profile view

(function() {

    'use strict';
    Severity: Minor
    Found in frontend/src/js/controllers/profileCtrl.js - About 3 hrs to fix

      Function updateProfile has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              vm.updateProfile = function(resetconfirmFormValid, editid) {
            if (resetconfirmFormValid) {
                vm.user.github_url = vm.user.github_url === null ? "" : vm.user.github_url;
                vm.user.google_scholar_url = vm.user.google_scholar_url === null ? "" : vm.user.google_scholar_url;
                vm.user.linkedin_url = vm.user.linkedin_url === null ? "" : vm.user.linkedin_url;
      Severity: Major
      Found in frontend/src/js/controllers/profileCtrl.js - About 2 hrs to fix

        Function changePassword has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                vm.changePassword = function(resetconfirmFormValid) {
            if(resetconfirmFormValid){
            var parameters = {};
            parameters.url = 'auth/password/change/';
            parameters.method = 'POST';
        Severity: Minor
        Found in frontend/src/js/controllers/profileCtrl.js - About 1 hr to fix

          Function editprofileDialog has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  vm.editprofileDialog = function(ev) {
            switch (ev.currentTarget.id) {
                case "first_name":
                  vm.titleInput = "First Name";
                  vm.editid = "first_name";
          Severity: Minor
          Found in frontend/src/js/controllers/profileCtrl.js - About 1 hr to fix

            Function profileCtrl has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                function profileCtrl(utilities, $rootScope, $scope, $mdDialog, moment, $state) {
            Severity: Minor
            Found in frontend/src/js/controllers/profileCtrl.js - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      try {
                            oldpassword_valid = typeof(response.data.old_password) !== 'undefined' ? true : false;
                            password1_valid = typeof(response.data.new_password1) !== 'undefined' ? true : false;
                            password2_valid = typeof(response.data.new_password2) !== 'undefined' ? true : false;
                            if (oldpassword_valid) {
              Severity: Major
              Found in frontend/src/js/controllers/profileCtrl.js and 1 other location - About 1 day to fix
              frontend/src/js/controllers/changePwdCtrl.js on lines 83..96

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 234.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                                              if (isFirstname_valid) {
                                    vm.FormError = response.data.first_name[0];
                                } else if (isLastname_valid) {
                                    vm.FormError = response.data.last_name[0];
                                } else if (isAffiliation_valid) {
              Severity: Major
              Found in frontend/src/js/controllers/profileCtrl.js and 2 other locations - About 3 hrs to fix
              frontend/src/js/controllers/contactUsCtrl.js on lines 78..87
              frontend/src/js/controllers/updateProfileCtrl.js on lines 121..129

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 108.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      vm.getAuthTokenDialog = function(ev) {
            vm.titleInput = "";
            $mdDialog.show({
                scope: $scope,
                preserveScope: true,
              Severity: Major
              Found in frontend/src/js/controllers/profileCtrl.js and 1 other location - About 1 hr to fix
              frontend/src/js/controllers/challengeCtrl.js on lines 2471..2480

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 67.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                          parameters.data = {
                "old_password": vm.user.old_password,
                "new_password1": vm.user.new_password1,
                "new_password2": vm.user.new_password2,
                "uid": $state.params.user_id,
              Severity: Major
              Found in frontend/src/js/controllers/profileCtrl.js and 3 other locations - About 1 hr to fix
              frontend/src/js/controllers/authCtrl.js on lines 96..101
              frontend/src/js/controllers/authCtrl.js on lines 342..347
              frontend/src/js/controllers/changePwdCtrl.js on lines 64..69

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 64.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                                      if (status == 200) {
                            utilities.resetStorage();
                            $rootScope.isLoader = false;
                            $state.go("home");
                            $rootScope.isAuth = false;
              Severity: Major
              Found in frontend/src/js/controllers/profileCtrl.js and 1 other location - About 1 hr to fix
              frontend/src/js/route-config/route-config.js on lines 766..772

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 58.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      vm.isURLValid = function(url) {
            if (url === undefined || url === null) {
                return true;
            }
            return (url.length <= 200);
              Severity: Minor
              Found in frontend/src/js/controllers/profileCtrl.js and 1 other location - About 40 mins to fix
              frontend/src/js/controllers/updateProfileCtrl.js on lines 57..62

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 49.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status