ClusterLabs/hawk

View on GitHub
hawk/app/assets/javascripts/module/constraints.js

Summary

Maintainability
C
1 day
Test Coverage

Function formatter has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        formatter: function(value, row, index) {
          var operations = [];

          switch(row.object_type) {
            case "location":
Severity: Major
Found in hawk/app/assets/javascripts/module/constraints.js - About 3 hrs to fix

    Function click .delete has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              'click .delete': function (e, value, row, index) {
                e.preventDefault();
                var $self = $(this);
                $.hawkAsyncConfirm(i18n.translate('Are you sure you wish to delete %s?').fetch(row.id), function() {
                  $.ajax({
    Severity: Minor
    Found in hawk/app/assets/javascripts/module/constraints.js - About 1 hr to fix

      Function constraintResources has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        var constraintResources = function(row) {
          var flattenResourceList = null;
          flattenResourceList = function(obj) {
            var t = $.type(obj);
            var ret = [];
      Severity: Minor
      Found in hawk/app/assets/javascripts/module/constraints.js - About 1 hr to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    case "colocation":
                      var editRoute = Routes.edit_cib_colocation_path(
                        $('body').data('cib'),
                        row.id
                      );
        Severity: Major
        Found in hawk/app/assets/javascripts/module/constraints.js and 3 other locations - About 1 hr to fix
        hawk/app/assets/javascripts/module/constraints.js on lines 146..157
        hawk/app/assets/javascripts/module/constraints.js on lines 170..181
        hawk/app/assets/javascripts/module/constraints.js on lines 182..193

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    case "order":
                      var editRoute = Routes.edit_cib_order_path(
                        $('body').data('cib'),
                        row.id
                      );
        Severity: Major
        Found in hawk/app/assets/javascripts/module/constraints.js and 3 other locations - About 1 hr to fix
        hawk/app/assets/javascripts/module/constraints.js on lines 146..157
        hawk/app/assets/javascripts/module/constraints.js on lines 158..169
        hawk/app/assets/javascripts/module/constraints.js on lines 182..193

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    case "location":
                      var editRoute = Routes.edit_cib_location_path(
                        $('body').data('cib'),
                        row.id
                      );
        Severity: Major
        Found in hawk/app/assets/javascripts/module/constraints.js and 3 other locations - About 1 hr to fix
        hawk/app/assets/javascripts/module/constraints.js on lines 158..169
        hawk/app/assets/javascripts/module/constraints.js on lines 170..181
        hawk/app/assets/javascripts/module/constraints.js on lines 182..193

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                    case "ticket":
                      var editRoute = Routes.edit_cib_ticket_path(
                        $('body').data('cib'),
                        row.id
                      );
        Severity: Major
        Found in hawk/app/assets/javascripts/module/constraints.js and 3 other locations - About 1 hr to fix
        hawk/app/assets/javascripts/module/constraints.js on lines 146..157
        hawk/app/assets/javascripts/module/constraints.js on lines 158..169
        hawk/app/assets/javascripts/module/constraints.js on lines 170..181

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status