ClusterLabs/hawk

View on GitHub
hawk/app/assets/javascripts/module/location.js

Summary

Maintainability
D
1 day
Test Coverage

Function rulesList has 141 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function rulesList(el, options) {
    this.$el = $(el);

    this.values = this.$el.data('locations');
    this.targets = this.$el.data('locations-target');
Severity: Major
Found in hawk/app/assets/javascripts/module/location.js - About 5 hrs to fix

    File location.js has 301 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    // Copyright (c) 2009-2015 Tim Serong <tserong@suse.com>
    // See COPYING for license.
    
    ;(function($) {
      'use strict';
    Severity: Minor
    Found in hawk/app/assets/javascripts/module/location.js - About 3 hrs to fix

      Function init has 62 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        rulesList.prototype.init = function() {
          var self = this;
      
          var content = {
            prefix: self.prefixes,
      Severity: Major
      Found in hawk/app/assets/javascripts/module/location.js - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          simpleui.on('click', ".dropdown-menu a", function() {
            var value = $(this).data('value');
            simpleui.find('#simple-score').val(value).trigger('change');
          }).on('change', "#simple-score", function() {
            var value = $(this).val();
        Severity: Major
        Found in hawk/app/assets/javascripts/module/location.js and 1 other location - About 1 hr to fix
        hawk/app/assets/javascripts/module/location.js on lines 282..293

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                $.observable(
                  content['entries'][$.view(this).parent.parent.getIndex()]['expressions']
                ).remove($.view(this).parent.getIndex());
        Severity: Minor
        Found in hawk/app/assets/javascripts/module/location.js and 1 other location - About 40 mins to fix
        hawk/app/assets/javascripts/module/constraint.js on lines 274..276

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status