ClusterLabs/hawk

File primitives.js has 390 lines of code (exceeds 250 allowed). Consider refactoring.

Open

// Copyright (c) 2009-2015 Tim Serong <tserong@suse.com>
// See COPYING for license.

$(function() {
  // Some craziness to avoid duplicating this stuff for both

Function render_attrlists has 130 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    var render_attrlists = function($template, $clazz, $provider, $type) {
      var new_resource = $('form#new_primitive, form#new_template').length > 0;
      var agent = null;
      if ($template.length > 0 && $template.val() != "") {
        agent = "@" + $template.val();

Function success has 91 lines of code (exceeds 25 allowed). Consider refactoring.

Open

          success: function(data) {
            if (data == null || !("resource_agent" in data)) {
              data = { resource_agent: {
                shortdesc: agent,
                longdesc: "",

Function click .delete has 41 lines of code (exceeds 25 allowed). Consider refactoring.

Open

            'click .delete': function (e, value, row, index) {
              e.preventDefault();
              var $self = $(this);
              var answer = null;

Function formatter has 30 lines of code (exceeds 25 allowed). Consider refactoring.

Open

          formatter: function(value, row, index) {
            var operations = []

            operations.push([
              '<a href="',

Avoid deeply nested control flow statements.

Open

                    if ($.type(root[lstname][elemname]) == "object") {
                      return [root[lstname][elemname]];
                    } else {
                      return root[lstname][elemname];
                    }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    $(controller_type.sel_readonly).each(function() {
      var $form = $(controller_type.form_selector);
      var $template = $form.find(controller_type.template_selector);
      var $clazz = $form.find(controller_type.clazz_selector);
      var $provider = $form.find(controller_type.provider_selector);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      .on('change', controller_type.selects, function(e) {
        var $form = $(e.delegateTarget);

        var $template = $form.find(controller_type.template_selector);
        var $clazz = $form.find(controller_type.clazz_selector);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ($type.find('[data-clazz="' + $clazz.val() + '"][data-provider="' + $provider.val() + '"][value="' + $type.val() + '"]').length == 0) {
          $type.val('');
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        if ($type.find('[data-clazz="' + $clazz.val() + '"][data-provider="' + $provider.val() + '"][value="' + $type.val() + '"]').length == 0) {
          $type.val('');
        }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $type
          .find('[data-clazz][data-provider]')
          .show()
          .not('[data-clazz="' + $clazz.val() + '"][data-provider="' + $provider.val() + '"]')
          .hide()

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        $type
          .find('[data-clazz][data-provider]')
          .show()
          .not('[data-clazz="' + $clazz.val() + '"][data-provider="' + $provider.val() + '"]')
          .hide()

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    template: {
      table_selector: '#templates #middle table.primitives, #configs #middle table.templates',
      cib_primitives_path: Routes.cib_templates_path,
      cib_primitive_path: Routes.cib_template_path,
      edit_cib_primitive_path: Routes.edit_cib_template_path,

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    primitive: {
      table_selector: '#primitives #middle table.primitives, #configs #middle table.primitives',
      cib_primitives_path: Routes.cib_primitives_path,
      cib_primitive_path: Routes.cib_primitive_path,
      edit_cib_primitive_path: Routes.edit_cib_primitive_path,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            $('[data-help-target]').each(function() {
              $($(this).data('help-target')).hide();
            });

• Read up
  Read up