Sign upLogin

Code-for-Miami/miami211

View on GitHub
Star

Showing 3 of 15 total issues

Function showRefined has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function showRefined(){
        let count = 0
        $(".each-result").each(function(){ // Go through each search result
            const this_result = $(this)
            if (refine_by.length === 0){ // If no checkbox is selected, show this result
Severity: Minor
Found in public/js/refine_by_category.js - About 1 hr to fix

    Method getServices has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def getServices(org)
        if settings.development?
            arr = ["Alpha", "Bravo", "Charlie", "Delta", "Echo", "Foxtrot", "Golf", "Hotel", "India"]
            org[:categories] = [arr[rand(0..2)], arr[rand(3..5)], arr[rand(6..8)]].sort
        else # Fetch categories for production only (fewer API calls)
    Severity: Minor
    Found in server.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getUrlParameter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    getUrlParameter = function getUrlParameter(sParam) {
    var sPageURL = decodeURIComponent(window.location.search.substring(1)),
        sURLVariables = sPageURL.split('&'),
        sParameterName,
        i;
    Severity: Minor
    Found in public/js/map_geo.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language