CodeTheChangeUBC/sasc

View on GitHub

Showing 49 of 160 total issues

Avoid too many return statements within this function.
Open

        return res.status(422).send({error: "Cannot create " + role + "because !results"});
Severity: Major
Found in server/controllers/authentication.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return res.status(201).send({success: "Successfully updated "+role+"."});
    Severity: Major
    Found in server/controllers/account.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return res.status(422).send({error: "Failed to update "+role+" account information."});
      Severity: Major
      Found in server/controllers/account.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return done(null, users[0]);
        Severity: Major
        Found in server/services/passport.js - About 30 mins to fix

          Function handleOnSubmit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              handleOnSubmit(ev) {
                  ev.preventDefault();
                  var ID;
                  var fields;
                  var validated = false;
          Severity: Minor
          Found in client/src/Containers/Account/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function count has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.count = function(model) {    
              return new Promise(function(fulfill, reject) {
                  db.get().query('SELECT COUNT(ID) AS count FROM '+model+';', function(err,results,fields) {            
                      if (err) { reject(err); }
                      if (results.length > 0) {
          Severity: Minor
          Found in server/models/abstract.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function handlePasswordChange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              handlePasswordChange(ev) {
                  ev.preventDefault();
                  const { oldPassword, newPassword, newPasswordConfirm } = this.state;
                  var validated = false;
                  if (this.props.auth === "user") {
          Severity: Minor
          Found in client/src/Containers/PasswordChange/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function checkRoleAndGetInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.checkRoleAndGetInfo = async function (req, res) {
          
              try {
                  const tokenContents = jwt.decode(req.body.token, config.secret);
                  const role = tokenContents.role;
          Severity: Minor
          Found in server/controllers/authentication.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function updateAccount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.updateAccount = async function (role, model, user, id, req, res) {
              // Check entered password before updating user information
              var err, users, isMatch;
              [err, users] = await to(model.lookupById(id));
              if (err) {
          Severity: Minor
          Found in server/controllers/account.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language