Sign upLogin

CodeTheChangeUBC/sasc

View on GitHub
Star
server/controllers/account.js

Summary

Maintainability
C
1 day
Test Coverage

Function changePassword has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.changePassword = async function (req, res, model) {
    var id = req.query.ID;
    var oldPassword = req.body.oldPassword;

    let err, oldPasswordHashed, newPasswordHashed, users, isMatch;
Severity: Minor
Found in server/controllers/account.js - About 1 hr to fix

    Function updateAccount has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    exports.updateAccount = async function (role, model, user, id, req, res) {
    Severity: Minor
    Found in server/controllers/account.js - About 45 mins to fix

      Function changePassword has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.changePassword = async function (req, res, model) {
    var id = req.query.ID;
    var oldPassword = req.body.oldPassword;

    let err, oldPasswordHashed, newPasswordHashed, users, isMatch;
      Severity: Minor
      Found in server/controllers/account.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return res.status(201).send({success: "Successfully updated "+role+"."});
      Severity: Major
      Found in server/controllers/account.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return res.status(422).send({error: "Failed to encrypt password."});
        Severity: Major
        Found in server/controllers/account.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return res.status(422).send({error: "Failed to encrypt password."});
          Severity: Major
          Found in server/controllers/account.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return res.status(422).send({error: "Failed to change password."});
            Severity: Major
            Found in server/controllers/account.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return res.status(422).send({error: "Failed to update "+role+" account information."});
              Severity: Major
              Found in server/controllers/account.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return res.status(201).send({success: "Successfully changed password."});
                Severity: Major
                Found in server/controllers/account.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return res.status(422).send({error: "Database "+role+" update error."});
                  Severity: Major
                  Found in server/controllers/account.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return res.status(422).send({error: "Failed to change password."});
                    Severity: Major
                    Found in server/controllers/account.js - About 30 mins to fix

                      Function updateAccount has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                      exports.updateAccount = async function (role, model, user, id, req, res) {
    // Check entered password before updating user information
    var err, users, isMatch;
    [err, users] = await to(model.lookupById(id));
    if (err) {
                      Severity: Minor
                      Found in server/controllers/account.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if (results.changedRows === 0) {
        return res.status(422).send({error: "Failed to update "+role+" account information."});
    }
                      Severity: Minor
                      Found in server/controllers/account.js and 2 other locations - About 40 mins to fix
                      server/controllers/account.js on lines 14..16
                      server/controllers/account.js on lines 38..40

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if (results.length === 0) {
        return res.status(422).send({error: "No such "+role+"."});
    }
                      Severity: Minor
                      Found in server/controllers/account.js and 2 other locations - About 40 mins to fix
                      server/controllers/account.js on lines 38..40
                      server/controllers/account.js on lines 58..60

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Similar blocks of code found in 3 locations. Consider refactoring.
                      Open

                          if (users.length === 0) {
        return res.status(422).send({error: "No such "+role+"."});
    }
                      Severity: Minor
                      Found in server/controllers/account.js and 2 other locations - About 40 mins to fix
                      server/controllers/account.js on lines 14..16
                      server/controllers/account.js on lines 58..60

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 48.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status