Sign upLogin

CodeTheChangeUBC/sasc

View on GitHub
Star
server/controllers/authentication.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function abstractSignup has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function abstractSignup(user, requiredCredentials, role, res, model) {
    var error = false;
    var missingCredentials = [];

    Object.keys(requiredCredentials).forEach(function (property) {
Severity: Minor
Found in server/controllers/authentication.js - About 1 hr to fix

    Function checkRoleAndGetInfo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.checkRoleAndGetInfo = async function (req, res) {

    try {
        const tokenContents = jwt.decode(req.body.token, config.secret);
        const role = tokenContents.role;
    Severity: Minor
    Found in server/controllers/authentication.js - About 1 hr to fix

      Function abstractSignup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      async function abstractSignup(user, requiredCredentials, role, res, model) {
    var error = false;
    var missingCredentials = [];

    Object.keys(requiredCredentials).forEach(function (property) {
      Severity: Minor
      Found in server/controllers/authentication.js - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function abstractSignup has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      async function abstractSignup(user, requiredCredentials, role, res, model) {
      Severity: Minor
      Found in server/controllers/authentication.js - About 35 mins to fix

        Avoid too many return statements within this function.
        Open

                return res.status(422).send({error: "Cannot create " + role + "because !results"});
        Severity: Major
        Found in server/controllers/authentication.js - About 30 mins to fix

          Function checkRoleAndGetInfo has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.checkRoleAndGetInfo = async function (req, res) {

    try {
        const tokenContents = jwt.decode(req.body.token, config.secret);
        const role = tokenContents.role;
          Severity: Minor
          Found in server/controllers/authentication.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status