client/app/bundles/course/assessment/submission/reducers/grading/index.js
Function default
has 137 lines of code (exceeds 25 allowed). Consider refactoring. Open
Open
export default function (state = initialState, action) {
switch (action.type) {
case actions.FETCH_SUBMISSION_SUCCESS: {
const { expMultiplier } = state;
const submission = action.payload.submission;
- Create a ticketCreate a ticket
Function default
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
Open
export default function (state = initialState, action) {
switch (action.type) {
case actions.FETCH_SUBMISSION_SUCCESS: {
const { expMultiplier } = state;
const submission = action.payload.submission;
- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this function. Open
Open
return {
...state,
exp: action.exp,
};
- Create a ticketCreate a ticket
Avoid too many return
statements within this function. Open
Open
return {
...state,
questions,
exp: computeExp(questions, maximumGrade, basePoints, expMultiplier),
};
- Create a ticketCreate a ticket
Avoid too many return
statements within this function. Open
Open
return state;
- Create a ticketCreate a ticket
Avoid too many return
statements within this function. Open
Open
return {
...state,
exp: computeExp(
questions,
maximumGrade,
- Create a ticketCreate a ticket