Sign upLogin

Coursemology/coursemology2

View on GitHub
Star
client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx

Summary

Maintainability
C
1 day
Test Coverage

Function CommentTabs has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const CommentTabs: FC<CommentTabProps> = (props) => {
  const { tabValue, intl } = props;
  const dispatch = useAppDispatch();
  const [tabTypesToRender, setTabTypesToRender] = useState(
    [] as CommentTabData[],
Severity: Minor
Found in client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx - About 1 hr to fix

Function getTabTypesToRender has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getTabTypesToRender = (
  permissions: CommentPermissions,
  tabInfo: CommentTabInfo,
): CommentTabData[] => {
  const tabs = [] as CommentTabTypes[];
Severity: Minor
Found in client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx - About 1 hr to fix

Function getTabTypesToRender has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

const getTabTypesToRender = (
  permissions: CommentPermissions,
  tabInfo: CommentTabInfo,
): CommentTabData[] => {
  const tabs = [] as CommentTabTypes[];
Severity: Minor
Found in client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function CommentIndex has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const CommentIndex: FC<Props> = (props) => {
  const { intl } = props;
  const dispatch = useAppDispatch();

  const settings = useAppSelector(getSettings);
Severity: Minor
Found in client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx - About 1 hr to fix

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  useEffect(() => {
    dispatch(fetchTabData())
      .catch(() =>
        toast.error(intl.formatMessage(translations.fetchCommentsFailure)),
      )
Severity: Major
Found in client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx and 3 other locations - About 1 hr to fix
client/app/bundles/announcements/GlobalAnnouncementIndex.tsx on lines 32..38
client/app/bundles/system/admin/admin/pages/AnnouncementsIndex.tsx on lines 45..51
client/app/bundles/system/admin/instance/instance/pages/InstanceAnnouncementsIndex.tsx on lines 50..56

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 4 locations. Consider refactoring.
Open

                style={{
                  minHeight: 48,
                  paddingRight:
                    tabData.count === 0 || tabData.count === undefined ? 8 : 26,
                  textDecoration: 'none',
Severity: Major
Found in client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx and 3 other locations - About 40 mins to fix
client/app/bundles/course/statistics/pages/StatisticsIndex/StatisticsTabs.tsx on lines 99..104
client/app/bundles/course/statistics/pages/StatisticsIndex/index.tsx on lines 98..103
client/app/bundles/course/users/components/navigation/UserManagementTabs.tsx on lines 151..156

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          <Page.PaddedSection>
            <TopicList key={tabValue} settings={settings} tabValue={tabValue} />
          </Page.PaddedSection>
Severity: Minor
Found in client/app/bundles/course/discussion/topics/pages/CommentIndex/index.tsx and 1 other location - About 40 mins to fix
client/app/bundles/course/experience-points/disbursement/components/forms/DisbursementForm.tsx on lines 245..251

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 49.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status