Sign upLogin

CrazySquirrel/ViewAbility

View on GitHub
Star

Showing 9 of 11 total issues

Function constructor has a Cognitive Complexity of 50 (exceeds 5 allowed). Consider refactoring.
Open

  constructor(domElement: any,
              objSetting: any,
              funCallBack: any = () => {
              },
              SubscriptionID?: string) {
Severity: Minor
Found in lib/ViewAbility.ts - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function constructor has 104 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  constructor(domElement: any,
              objSetting: any,
              funCallBack: any = () => {
              },
              SubscriptionID?: string) {
Severity: Major
Found in lib/ViewAbility.ts - About 4 hrs to fix

Function watch has a Cognitive Complexity of 27 (exceeds 5 allowed). Consider refactoring.
Open

  public watch() {
    if (
        this.domElement &&
        typeof this.domElement === "object"
    ) {
Severity: Minor
Found in lib/ViewAbility.ts - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

ViewAbility has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class ViewAbility implements IViewAbility {

  /**
   * @deprecated ViewAbility.numDocumentWidth was deprecated, please use UtilsDOMVisibility.numDocumentWidth instead
   */
Severity: Minor
Found in lib/ViewAbility.ts - About 2 hrs to fix

File ViewAbility.ts has 275 lines of code (exceeds 250 allowed). Consider refactoring.
Open

"use strict";
/**
 * Import interfaces
 */
import IWindow from "../interfaces/IWindow";
Severity: Minor
Found in lib/ViewAbility.ts - About 2 hrs to fix

Function watch has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public watch() {
    if (
        this.domElement &&
        typeof this.domElement === "object"
    ) {
Severity: Minor
Found in lib/ViewAbility.ts - About 1 hr to fix

Consider simplifying this complex logical expression.
Open

    if (
        domElement &&
        typeof domElement === "object" &&
        domElement.nodeType === 1 &&
        domElement.parentElement &&
Severity: Major
Found in lib/ViewAbility.ts - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

      if (
          typeof this.ID !== "string" &&
          this.domElement &&
          typeof this.domElement === "object" &&
          this.domElement.nodeType === 1 &&
Severity: Major
Found in lib/ViewAbility.ts - About 40 mins to fix

Consider simplifying this complex logical expression.
Open

    if (
        (
            domElement ||
            typeof this.ID === "string"
        ) &&
Severity: Major
Found in lib/ViewAbility.ts - About 40 mins to fix
Severity
Category
Status
Source
Language