Sign upLogin

DEFRA/hapi-pg-rest-api

View on GitHub
Star

Showing 7 of 19 total issues

Function getSchema has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const getSchema = async (request, h) => {
  const config = request.route.settings.plugins.hapiPgRestAPI
  const { table, primaryKey, primaryKeyAuto, primaryKeyGuid } = config
  const required = []
Severity: Minor
Found in src/schema-controller.js - About 1 hr to fix

    Function create has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const create = async (request, h) => {
  const config = request.route.settings.plugins.hapiPgRestAPI
  const repo = manager.get(config.name)
  const { columns, data: payload } = await getRequestData(request, config)
    Severity: Minor
    Found in src/controller.js - About 1 hr to fix

      Function updateOne has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const updateOne = async (request, h) => {
  const config = request.route.settings.plugins.hapiPgRestAPI
  const repo = manager.get(config.name)
  const { columns, filter } = await getRequestData(request, config)
      Severity: Minor
      Found in src/controller.js - About 1 hr to fix

        Function makeRequest has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          async makeRequest (options) {
    try {
      return await this.rp(options)
    } catch (error) {
      if (error.statusCode < 500) {
        Severity: Minor
        Found in src/api-client.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return errorReply(error, h)
        Severity: Major
        Found in src/controller.js - About 30 mins to fix

          Function createRoute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          const createRoute = (config, method, handler, isMany = false) => {
  const { endpoint, table } = config
  const description = `${method} ${isMany ? 'many' : 'single'} ${table} ${isMany ? 'records' : 'record'}`
  const path = (isMany || method === 'POST') ? endpoint : `${endpoint}/{id*}`
  const route = {
          Severity: Minor
          Found in src/route-factory.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getRequestData has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          const getRequestData = (request, config) => {
  const { filter: filterStr, sort, pagination, columns } = request.query

  const filter = filterStr ? JSON.parse(filterStr) : {}
          Severity: Minor
          Found in src/helpers.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language