Sign upLogin

Dallinger/Dallinger

View on GitHub
Star
demos/dlgr/demos/twentyfortyeight/static/scripts/game_manager.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function tileMatchesAvailable has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

GameManager.prototype.tileMatchesAvailable = function () {
  var self = this;

  var tile;
Severity: Minor
Found in demos/dlgr/demos/twentyfortyeight/static/scripts/game_manager.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function move has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

GameManager.prototype.move = function (direction) {
  // 0: up, 1: right, 2: down, 3: left
  var self = this;

  if (this.isGameTerminated()) return; // Don't do anything if the game's over
Severity: Minor
Found in demos/dlgr/demos/twentyfortyeight/static/scripts/game_manager.js - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

          if (other && other.value === tile.value) {
            return true; // These two tiles can be merged
          }
Severity: Major
Found in demos/dlgr/demos/twentyfortyeight/static/scripts/game_manager.js - About 45 mins to fix

There are no issues that match your filters.

Category
Status