Showing 2 of 116 total issues
Method scrape_breweries has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
Open
def scrape_breweries
brewery_info = doc.css('#tabs table')
@breweries = brewery_info.flat_map.with_index do |tbl, i|
status = i == 0 ? 'Active' : 'Out of Business'
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method included has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
Open
def self.included(base)
if base.respond_to?(:data_keys)
base.data_keys.each do |attr|
define_method(attr) do
send("scrape_#{attr}") unless instance_variable_defined?("@#{attr}")- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"