Sign upLogin

DannyBen/audio_addict

View on GitHub
Star

Showing 2 of 2 total issues

Method generate_command has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def generate_command(name = nil)
        needs :network, :channel, :listen_key

        require_premium_account
Severity: Minor
Found in lib/audio_addict/commands/playlist.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method channel_menu has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

      def channel_menu(channel = nil)
        list = channel ? radio.search(channel).values : radio.channels.values

        if list.count == 1
          save_channel list.first.key
Severity: Minor
Found in lib/audio_addict/commands/set.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language