DannyBen/madness

View on GitHub

Showing 4 of 6 total issues

Method search has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def search(query)
      query = query.downcase
      words = Shellwords.split query
      word_count = words.count
      result = {}
Severity: Minor
Found in lib/madness/search.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method override_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Confirmed

      def override_config(args)
        config.path       = args['PATH'] if args['PATH']
        config.port       = args['--port'].to_i if args['--port']
        config.bind       = args['--bind'] if args['--bind']
        config.auth       = args['--auth'] if args['--auth']
Severity: Minor
Found in lib/madness/commands/server.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method open has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Confirmed

    def open
      fork do
        if server_running?
          success = open!
          yield success ? nil : "Failed opening browser (#{open_command.join ' '})"
Severity: Minor
Found in lib/madness/browser.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method index! has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def index!
      results = {}

      Dir["#{@path}/**/#{config.dir_glob}"].each do |file|
        next if skip_index? file
Severity: Minor
Found in lib/madness/search.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language