Sign upLogin

DaoCasino/bankroller-core

View on GitHub
Star
lib/dapps/DApp.js

Summary

Maintainability
F
3 days
Test Coverage

Function channelState has a Cognitive Complexity of 36 (exceeds 15 allowed). Consider refactoring.
Open

const channelState = function (player_openkey = false) {
  if (!player_openkey) {
    console.error(' player_openkey required in channelState constructor')
    return
  }
Severity: Minor
Found in lib/dapps/DApp.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File DApp.js has 546 lines of code (exceeds 500 allowed). Consider refactoring.
Open

import _config         from 'config'
import path            from 'path'
import * as messaging  from 'dc-messaging'
import PQueue          from 'p-queue'
import Eth             from 'Eth'
Severity: Major
Found in lib/dapps/DApp.js - About 3 hrs to fix

    Function _call has a Cognitive Complexity of 27 (exceeds 15 allowed). Consider refactoring.
    Open

      async _call (data) {
    const user = this.users[data.user_id]
    if (!data.data || !data.data.gamedata || !data.data.seed) return
    if (!data.func || !data.func.name || !data.func.args) return
    Severity: Minor
    Found in lib/dapps/DApp.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _call has 120 lines of code (exceeds 100 allowed). Consider refactoring.
    Open

      async _call (data) {
    const user = this.users[data.user_id]
    if (!data.data || !data.data.gamedata || !data.data.seed) return
    if (!data.func || !data.func.name || !data.func.args) return
    Severity: Major
    Found in lib/dapps/DApp.js - About 1 hr to fix

      Function _newUser has a Cognitive Complexity of 21 (exceeds 15 allowed). Consider refactoring.
      Open

        async _newUser (params) {
    const connection_id = Utils.makeSeed()
    const user_id       = params.user_id

    if (this.users[user_id]) delete this.users[user_id]
      Severity: Minor
      Found in lib/dapps/DApp.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function channelState has 104 lines of code (exceeds 100 allowed). Consider refactoring.
      Open

      const channelState = function (player_openkey = false) {
  if (!player_openkey) {
    console.error(' player_openkey required in channelState constructor')
    return
  }
      Severity: Major
      Found in lib/dapps/DApp.js - About 1 hr to fix

        Avoid too many return statements within this function.
        Open

              return
        Severity: Major
        Found in lib/dapps/DApp.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return false
          Severity: Major
          Found in lib/dapps/DApp.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                if (!confirmed) return
            Severity: Major
            Found in lib/dapps/DApp.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return
              Severity: Major
              Found in lib/dapps/DApp.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return true
                Severity: Major
                Found in lib/dapps/DApp.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return
                  Severity: Major
                  Found in lib/dapps/DApp.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return
                    Severity: Major
                    Found in lib/dapps/DApp.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return false
                      Severity: Major
                      Found in lib/dapps/DApp.js - About 30 mins to fix

                        TODO found
                        Open

                                // rnd      : rnd // TODO: check
                        Severity: Minor
                        Found in lib/dapps/DApp.js by fixme

                        TODO found
                        Open

                              // TODO: openDispute
                        Severity: Minor
                        Found in lib/dapps/DApp.js by fixme

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              const state_hash = Utils.sha3(
        {t: 'bytes32' , v: state_data._id                }   ,
        {t: 'uint'    , v: state_data._playerBalance     }   ,
        {t: 'uint'    , v: state_data._bankrollerBalance }   ,
        {t: 'uint'    , v: state_data._totalBet          }   ,
                        Severity: Major
                        Found in lib/dapps/DApp.js and 1 other location - About 2 hrs to fix
                        lib/dapps/DApp.js on lines 130..136

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 94.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              const player_state_hash = Utils.sha3(
        {t: 'bytes32', v: state_data._id                },
        {t: 'uint',    v: state_data._playerBalance     },
        {t: 'uint',    v: state_data._bankrollerBalance },
        {t: 'uint',    v: state_data._totalBet          },
                        Severity: Major
                        Found in lib/dapps/DApp.js and 1 other location - About 2 hrs to fix
                        lib/dapps/DApp.js on lines 109..115

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 94.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            getPlayerSigned (hash = false) {
      if (!hash) hash = Object.keys(states).splice(-1)
      return GetState(hash).player
    },
                        Severity: Major
                        Found in lib/dapps/DApp.js and 1 other location - About 1 hr to fix
                        lib/dapps/DApp.js on lines 193..196

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 55.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            getBankrollerSigned (hash = false) {
      if (!hash) hash = Object.keys(states).splice(-1)
      return GetState(hash).bankroller
    }
                        Severity: Major
                        Found in lib/dapps/DApp.js and 1 other location - About 1 hr to fix
                        lib/dapps/DApp.js on lines 188..191

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 55.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status