Sign upLogin

DemocracyOS/democracyos

View on GitHub
Star
lib/api-v2/db-api/topics/index.js

Summary

Maintainability
D
2 days
Test Coverage

File index.js has 332 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const ObjectID = require('mongoose').Types.ObjectId
const Topic = require('lib/models').Topic
const Vote = require('lib/models').Vote
const Comments = require('../comments')
const scopes = require('./scopes')
Severity: Minor
Found in lib/api-v2/db-api/topics/index.js - About 4 hrs to fix

    Function getTags has 72 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.getTags = function getTags (opts) {
  const forum = new ObjectID(opts.forum._id)
  let sort = { 'count': -1 }
  if (opts.sort) {
    switch (opts.sort) {
    Severity: Major
    Found in lib/api-v2/db-api/topics/index.js - About 2 hrs to fix

      Function create has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports.create = function create (opts, attrs) {
  const user = opts.user
  const forum = opts.forum

  attrs.forum = forum._id
      Severity: Minor
      Found in lib/api-v2/db-api/topics/index.js - About 1 hr to fix

        Function doVote has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function doVote (user, value, topic) {
  if (topic.status === 'closed') {
    const err = new Error('Voting on this topic os closed.')
    err.code = 'VOTING_CLOSED'
    return Promise.reject(err)
        Severity: Minor
        Found in lib/api-v2/db-api/topics/index.js - About 1 hr to fix

          Function getTags has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

          exports.getTags = function getTags (opts) {
  const forum = new ObjectID(opts.forum._id)
  let sort = { 'count': -1 }
  if (opts.sort) {
    switch (opts.sort) {
          Severity: Minor
          Found in lib/api-v2/db-api/topics/index.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                attrs['action.results'] = [
        { value: '-100', percentage: 0, votes: 0 },
        { value: '-75', percentage: 0, votes: 0 },
        { value: '-50', percentage: 0, votes: 0 },
        { value: '-25', percentage: 0, votes: 0 },
          Severity: Major
          Found in lib/api-v2/db-api/topics/index.js and 1 other location - About 6 hrs to fix
          lib/api-v2/middlewares/topics.js on lines 131..141

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 156.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                attrs['action.results'] = [
        { value: 'positive', percentage: 0, votes: 0 },
        { value: 'neutral', percentage: 0, votes: 0 },
        { value: 'negative', percentage: 0, votes: 0 }
      ]
          Severity: Minor
          Found in lib/api-v2/db-api/topics/index.js and 1 other location - About 55 mins to fix
          lib/api-v2/middlewares/topics.js on lines 113..117

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 54.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status