Sign upLogin

DemocracyOS/democracyos

View on GitHub
Star
migrations/1501737026342-update-topic-box.js

Summary

Maintainability
C
1 day
Test Coverage

Function up has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports.up = function up (done) {
  dbReady()
    .then(() => Topic.collection.find({}).toArray())
    .then(mapPromises(function (topic) {
      if (topic.action && Object.keys(topic.action).includes('box')) return Promise.resolve(0)
Severity: Major
Found in migrations/1501737026342-update-topic-box.js - About 2 hrs to fix

    Function down has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.down = function down (done) {
  dbReady()
    .then(() => Topic.collection.find({}).toArray())
    .then(mapPromises(function (topic) {
      if (!topic.action || !Object.keys(topic.action).includes('box')) return Promise.resolve(0)
    Severity: Minor
    Found in migrations/1501737026342-update-topic-box.js - About 1 hr to fix

      Function up has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.up = function up (done) {
  dbReady()
    .then(() => Topic.collection.find({}).toArray())
    .then(mapPromises(function (topic) {
      if (topic.action && Object.keys(topic.action).includes('box')) return Promise.resolve(0)
      Severity: Minor
      Found in migrations/1501737026342-update-topic-box.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function down has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      exports.down = function down (done) {
  dbReady()
    .then(() => Topic.collection.find({}).toArray())
    .then(mapPromises(function (topic) {
      if (!topic.action || !Object.keys(topic.action).includes('box')) return Promise.resolve(0)
      Severity: Minor
      Found in migrations/1501737026342-update-topic-box.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

        dbReady()
    .then(() => Topic.collection.find({}).toArray())
    .then(mapPromises(function (topic) {
      if (topic.action && Object.keys(topic.action).includes('box')) return Promise.resolve(0)
      const action = {
      Severity: Major
      Found in migrations/1501737026342-update-topic-box.js and 10 other locations - About 1 hr to fix
      migrations/1487112733700-update-users-maxlengths.js on lines 15..57
      migrations/1487112733702-update-topic-maxlengths.js on lines 16..66
      migrations/1487113137271-add-topic-owner.js on lines 59..74
      migrations/1487786060173-update-topic-action.js on lines 10..30
      migrations/1487786060173-update-topic-action.js on lines 38..59
      migrations/1495224425289-add-participant-count.js on lines 9..24
      migrations/1495224425289-add-participant-count.js on lines 32..47
      migrations/1501737026342-update-topic-box.js on lines 90..124
      migrations/1503256241267-update-topic-votes.js on lines 11..39
      migrations/1503256241267-update-topic-votes.js on lines 47..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

        dbReady()
    .then(() => Topic.collection.find({}).toArray())
    .then(mapPromises(function (topic) {
      if (!topic.action || !Object.keys(topic.action).includes('box')) return Promise.resolve(0)
      const action = {
      Severity: Major
      Found in migrations/1501737026342-update-topic-box.js and 10 other locations - About 1 hr to fix
      migrations/1487112733700-update-users-maxlengths.js on lines 15..57
      migrations/1487112733702-update-topic-maxlengths.js on lines 16..66
      migrations/1487113137271-add-topic-owner.js on lines 59..74
      migrations/1487786060173-update-topic-action.js on lines 10..30
      migrations/1487786060173-update-topic-action.js on lines 38..59
      migrations/1495224425289-add-participant-count.js on lines 9..24
      migrations/1495224425289-add-participant-count.js on lines 32..47
      migrations/1501737026342-update-topic-box.js on lines 32..82
      migrations/1503256241267-update-topic-votes.js on lines 11..39
      migrations/1503256241267-update-topic-votes.js on lines 47..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 61.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const votesCounts = votes.reduce((counts, result) => {
    if (!counts[result.value]) counts[result.value] = 0
    counts[result.value]++
    return counts
  }, {})
      Severity: Minor
      Found in migrations/1501737026342-update-topic-box.js and 1 other location - About 40 mins to fix
      lib/api-v2/db-api/topics/utils.js on lines 71..75

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 49.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            if (!topic.action || !Object.keys(topic.action).includes('box')) return Promise.resolve(0)
      Severity: Minor
      Found in migrations/1501737026342-update-topic-box.js and 1 other location - About 35 mins to fix
      migrations/1503256241267-update-topic-votes.js on lines 14..14

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status