DerDu/SPHERE-Framework

View on GitHub

Showing 5,014 of 7,620 total issues

Method countOrientation has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static function countOrientation(
        TblStudent $tblStudent,
        TblLevel $tblLevel,
        $gender,
        $countOrientationArray

    Method countDivisionStudentsForSecondarySchool has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function countDivisionStudentsForSecondarySchool(
            &$countDivisionStudents,
            TblDivision $tblDivision,
            TblLevel $tblLevel,
            TblCourse $tblCourse = null,

      Method performQueryAnalysis has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function performQueryAnalysis($query) {
              if (preg_match('/^\\s*SELECT\\s\\*/i', $query)) {
                  $this->hints[] = 'Use <code>SELECT *</code> only if you need all columns from table';
              }
              if (preg_match('/ORDER BY RAND()/i', $query)) {
      Severity: Minor
      Found in xplain/app/Explainer.class.php - About 1 hr to fix

        Method performQueryAnalysis has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function performQueryAnalysis($query) {
                if (preg_match('/^\\s*SELECT\\s*`?[a-zA-Z0-9]*`?\\.?\\*/i', $query)) {
                    $this->hints[] = 'Use <code>SELECT *</code> only if you need all columns from table';
                }
                if (preg_match('/ORDER BY RAND()/i', $query)) {
        Severity: Minor
        Found in xplain/app/Explainer.php - About 1 hr to fix

          Method saveCreateAddressToPersonModal has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function saveCreateAddressToPersonModal($PersonId, $Street, $City, $State, $Type, $County, $Nation, $Relationship)
          Severity: Major
          Found in Application/Api/Contact/ApiAddressToPerson.php - About 1 hr to fix

            Method saveEditAddressToCompanyModal has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function saveEditAddressToCompanyModal($CompanyId, $ToCompanyId, $Street, $City, $State, $Type, $County, $Nation)
            Severity: Major
            Found in Application/Api/Contact/ApiAddressToCompany.php - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                      if ($Additional
                          && $Reorder
                          && isset($Additional['PrepareId'])
                          && isset($Additional['PersonId'])
                          && ($tblPrepare = \SPHERE\Application\Education\Certificate\Prepare\Prepare::useService()->getPrepareById($Additional['PrepareId']))
              Severity: Major
              Found in Application/Api/Education/Prepare/Prepare.php - About 1 hr to fix

                Consider simplifying this complex logical expression.
                Open

                                    if (isset($languagesWithStartLevel['Lane']) && isset($languagesWithStartLevel['Rank'])
                                        && $languagesWithStartLevel['Lane'] == $Lane && $languagesWithStartLevel['Rank'] == $count
                                    ) {
                                        $hasAdditionalLine['Lane'] = $Lane;
                                        $hasAdditionalLine['Ranking'] = 2;
                Severity: Major
                Found in Application/Api/Education/Certificate/Generator/Certificate.php - About 1 hr to fix

                  Consider simplifying this complex logical expression.
                  Open

                                  if (($tblConsumer = \SPHERE\Application\Platform\Gatekeeper\Authorization\Consumer\Consumer::useService()->getConsumerBySession())
                                      && $tblConsumer->getAcronym() == 'ESZC'
                                  ) {
                                      if (strpos(strtolower($tblSubject->getName()), 'naturwissen') !== false
                                          && $this->getTblDivision()
                  Severity: Major
                  Found in Application/Api/Education/Certificate/Generator/Certificate.php - About 1 hr to fix

                    Method getGradeLanesForRadebeul has 8 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            $personId,
                            $TextColor = 'black',
                            $TextSize = '13px',
                            $GradeFieldBackgroundColor = 'rgb(224,226,231)',
                            $IsGradeUnderlined = false,
                    Severity: Major
                    Found in Application/Api/Education/Certificate/Generator/Certificate.php - About 1 hr to fix

                      Method setCourseSubject has 8 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              TblSubject $tblSubject = null,
                              Section $section,
                              $isSubjectUnderlined,
                              $isGradeUnderlined,
                              $personId,

                        Method frontendSerialLetterPersonSelected has 8 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                $Id = null,
                                $FilterGroup = null,
                                $FilterStudent = null,
                                $FilterPerson = null,
                                $FilterYear = null,
                        Severity: Major
                        Found in Application/Reporting/SerialLetter/Frontend.php - About 1 hr to fix

                          Method updateListObjectElementList has 8 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  IFormInterface $Stage = null,
                                  $Id = null,
                                  $Data = null,
                                  $HasData = null,
                                  $objectList = null,
                          Severity: Major
                          Found in Application/Reporting/CheckList/Service.php - About 1 hr to fix

                            Method frontendListObjectElementEdit has 8 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    $ObjectId = null,
                                    $ListId = null,
                                    $ObjectTypeId = null,
                                    $Data = null,
                                    $YearPersonId = null,
                            Severity: Major
                            Found in Application/Reporting/CheckList/Frontend.php - About 1 hr to fix

                              Method createTestPicture has 8 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function createTestPicture($Name, $FileName, $Extension, $File, $Type, $Size, $Width, $Height)
                              Severity: Major
                              Found in Application/Platform/System/Test/Service/Data.php - About 1 hr to fix

                                Method createInvoice has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        $IntegerNumber,
                                        $Month,
                                        $Year,
                                        $TargetTime,
                                        $BillTime,
                                Severity: Major
                                Found in Application/Billing/Bookkeeping/Invoice/Service/Data.php - About 1 hr to fix

                                  Method importSupport has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public function importSupport(TblPerson $tblPerson,
                                          TblSupportType $tblSupportType,
                                          $Date = '',
                                          $Company = '',
                                          $PersonSupport = '',
                                  Severity: Major
                                  Found in Application/People/Meta/Student/Service/Service/Support.php - About 1 hr to fix

                                    Method insertStudentTransfer has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                    Open

                                            TblStudent $tblStudent,
                                            TblStudentTransferType $tblStudentTransferType,
                                            TblCompany $tblCompany = null,
                                            TblType $tblType = null,
                                            TblCourse $tblCourse = null,
                                    Severity: Major
                                    Found in Application/People/Meta/Student/Service/Service/Transfer.php - About 1 hr to fix

                                      Method createSupport has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                      Open

                                          public function createSupport(TblPerson $serviceTblPerson,
                                              TblSupportType $tblSupportType,
                                              $Date,
                                              $PersonEditor = '',
                                              $Company = '',
                                      Severity: Major
                                      Found in Application/People/Meta/Student/Service/Data/Support.php - About 1 hr to fix

                                        Method createStudentIntegration has 8 arguments (exceeds 4 allowed). Consider refactoring.
                                        Open

                                                TblPerson $tblPerson = null,
                                                TblCompany $tblCompany = null,
                                                $CoachingRequestDate,
                                                $CoachingCounselDate,
                                                $CoachingDecisionDate,
                                        Severity: Major
                                        Found in Application/People/Meta/Student/Service/Data/Integration.php - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language